Repository navigation
Generate authentication files before dev server hooks. - #828
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate the customized authentication schema and database module during the routing plugin’s
configureServerhook, so later startup hooks can import app code that references authentication tables. Document lazy imports for schema-dependent auth hooks sovoid preparecan generate those tables on a fresh clone.The fresh Cloudflare smoke test also passes on current main with a correctly configured alias. The failing regression directly exercises availability of the generated files before later startup hooks.
Adds fresh-app coverage for
void prepareand Cloudflare dev startup, including a foreign key touserTableand a custom authentication field.Validation:
vp test run --pool forks,vp run build:all,vp run check, formatting, linting, and build-artifact checks.The default full-suite run hit a native Node 24/V8 WebAssembly JIT assertion (
end > addr); forked-worker verification completed successfully.Refs #823.