Repository navigation
Apply title templates to default error page titles. - #827
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default 404 and 500 boundary titles were added after head resolution, so they bypassed
titleTemplate. Apply project or middleware templates to those default titles while preserving explicit titles and the correct title when a failing 404 boundary escalates to a 500 boundary.Covers HTML responses, Pages navigation payloads, and browser tab titles across React, Vue, Svelte, and Solid. A custom error-page title API remains separate from this fix.
Validation:
vp test run --pool forks,vp run build:all,vp run check, formatting, linting, and build-artifact checks.The default full-suite run hit a native Node 24/V8 WebAssembly JIT assertion (
end > addr); forked-worker verification completed successfully.Refs #825.