Repository navigation
jitv2: wake the compile pool only when a worker sleeps - #769
Merged
Merged
Conversation
The producer of compile requests is the CPU thread, and since the pool started parking it took the wake-up mutex and unparked every worker on every push -- including a push dropped on a full queue, which is when it pushes most (every dispatch of an uncompiled page retries). Workers now count themselves in CompileWake::sleepers before re-checking the lanes and parking; the producer wakes the pool only after an accepted push and only if that count is non-zero. A SeqCst fence on each side keeps the check-then-park race from losing a wakeup. The flush/seal leader and stop() still wake every worker unconditionally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The producer of compile requests is the CPU thread, and since the pool started parking it took the wake-up mutex and unparked every worker on every push -- including a push dropped on a full queue, which is when it pushes most (every dispatch of an uncompiled page retries).
Workers now count themselves in CompileWake::sleepers before re-checking the lanes and parking; the producer wakes the pool only after an accepted push and only if that count is non-zero. A SeqCst fence on each side keeps the check-then-park race from losing a wakeup. The flush/seal leader and stop() still wake every worker unconditionally.