Repository navigation
Add classes to all loo warnings - #417
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 92.72% 92.88% +0.16%
==========================================
Files 31 31
Lines 3270 3289 +19
==========================================
+ Hits 3032 3055 +23
+ Misses 238 234 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6ad3e76 is merged into master:
Further explanation regarding interpretation and methodology can be found in the documentation. |
jgabry
left a comment
There was a problem hiding this comment.
Looks good. I made a few suggestions, but pretty small.
jgabry
left a comment
There was a problem hiding this comment.
Looks good, this is basically ready. I made a few code formatting (indentation) comments and suggested an edit to the NEWS entry.
Co-authored-by: Jonah Gabry <jgabry@gmail.com>
jgabry
left a comment
There was a problem hiding this comment.
Looks good, thanks @florence-bockting
Description
This PR adds a class to each loo warning, following up on our corresponding work in the
posteriorpackage: stan-dev/posterior#470.loo_warningand a class for its cause.loo_warning_diagnostic.R/loo-package.RrlangtoImports.throw_psis_r_eff_warning()andthrow_loo_r_eff_warning()(this was dead code)This PR is related to Issue #353 (but does not fully solve it).
The PR was assisted by an LLM.