Repository navigation
Conversation
Fixes spdx#809 by checking license_id uniqueness in extracted-license list validation, with duplicate and distinct IDs tested through both list and full-document validation. Signed-off-by: Behzad Motaghi <behzad@motaghi.dk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted-license validation accepted records with the same
license_id, even when their extracted text differed. Track identifiers within each list and report repeated IDs with the affected license as context. Full-document validation uses this same check. Fixes #809.Tests cover duplicate and distinct identifiers through list and full-document validation. Both duplicate cases fail before the fix. Afterward the validation tests and the full SPDX 2 test suite pass. Changed-file isort, Black and flake8 checks pass.
I used gpt-6.1-sol via Codex, run from T3 Code, to write the patch and tests, and Claude Opus 5.5 reviewed the change independently. I've read and verified the diff myself.