Skip to content

docs: clarify recording and playback parameters in playrec - #647

Open
kushaldave002 wants to merge 1 commit into
spatialaudio:masterfrom
kushaldave002:docs/playrec-channel-directions
Open

kushaldave002 wants to merge 1 commit into
spatialaudio:masterfrom
kushaldave002:docs/playrec-channel-directions

Conversation

@kushaldave002

Copy link
Copy Markdown

Fixes #388

playrec() describes channels and dtype as input parameters, which can be mistaken for the playback array rather than the audio device's recording inputs.

Describe the channels, data types, and mappings in terms of recording and playback. Clarify that out is the function's output array containing recorded audio from the device's input channels. Function and parameter names stay unchanged.

Validation:

  • Strict Sphinx HTML builds pass, including the locked documentation dependency build; inspected the generated playrec() reference and its rec()/play() links.
  • Pyright reports 0 errors.
  • Module import, device listing, and PortAudio version smoke checks pass on macOS.
  • AST comparison confirms runtime code is unchanged.

External linkcheck was stopped after GitHub rate-limited unchanged example-source URLs; it is not claimed to pass.

Problem
Hardware input/output terminology can make channels, dtype, and out seem
to refer to the opposite side of simultaneous playback and recording.

Solution
Describe channels, dtype, and mappings in terms of recording and playback.
Explain that out holds recorded data from the device's input channels.

Result
The playrec reference makes each parameter's direction explicit without
changing function names, arguments, or runtime behavior.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why channels argument of playrec() determines the number of INPUT channels?

1 participant