Skip to content

Accept supported xlrd path inputs #16802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamabhisheknag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept supported xlrd path inputs #16802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stubs/xlrd/xlrd/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
from _typeshed import SupportsWrite
from _typeshed import StrOrBytesPath, StrPath, SupportsWrite
from typing import Final

from . import timemachine as timemachine
Expand All @@ -24,9 +24,9 @@ FILE_FORMAT_DESCRIPTIONS: Final[dict[str, str]]
ZIP_SIGNATURE: Final[bytes]
PEEK_SIZE: Final[int]

def inspect_format(path: str | None = None, content: bytes | None = None) -> str | None: ...
def inspect_format(path: StrPath | None = None, content: bytes | None = None) -> str | None: ...
def open_workbook(
filename: str | None = None,
filename: StrOrBytesPath | None = None,
logfile: SupportsWrite[str] = sys.stdout,
verbosity: int = 0,
use_mmap: bool = True,
Expand All @@ -37,5 +37,5 @@ def open_workbook(
ragged_rows: bool = False,
ignore_workbook_corruption: bool = False,
) -> Book: ...
def dump(filename: str, outfile: SupportsWrite[str] = sys.stdout, unnumbered: bool = False) -> None: ...
def count_records(filename: str, outfile: SupportsWrite[str] = sys.stdout) -> None: ...
def dump(filename: StrOrBytesPath, outfile: SupportsWrite[str] = sys.stdout, unnumbered: bool = False) -> None: ...
def count_records(filename: StrOrBytesPath, outfile: SupportsWrite[str] = sys.stdout) -> None: ...
6 changes: 3 additions & 3 deletions stubs/xlrd/xlrd/book.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
from _typeshed import SupportsWrite
from _typeshed import StrOrBytesPath, SupportsWrite
from collections.abc import Iterator
from types import TracebackType
from typing import Final, Literal
Expand All @@ -23,7 +23,7 @@ builtin_name_from_code: Final[dict[str, str]]
code_from_builtin_name: Final[dict[str, str]]

def open_workbook_xls(
filename: str | None = None,
filename: StrOrBytesPath | None = None,
logfile: SupportsWrite[str] = sys.stdout,
verbosity: int = 0,
use_mmap: bool = True,
Expand Down Expand Up @@ -104,7 +104,7 @@ class Book(BaseObject):
base: int
def biff2_8_load(
self,
filename: str | None = None,
filename: StrOrBytesPath | None = None,
file_contents: bytes | None = None,
logfile: SupportsWrite[str] = sys.stdout,
verbosity: int = 0,
Expand Down
Loading