Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Durationdefines__neg__but not__abs__or__pos__, soabs()and unary+fall back totimedeltaand return a plaindatetime.timedelta. Years and months are folded into days and theDurationmethods are lost:This adds
__pos__(returns the duration itself) and__abs__(returns-selfwhen the total is negative, using the existing__neg__), so both now return aDurationwith years and months kept.Intervalkeeps its own__abs__;+intervalnow returns the interval instead of atimedelta. As withtimedelta, the sign of a mixed-sign duration is decided bytotal_seconds()(which uses the usual 365/30-day approximation for years and months).Added
test_absandtest_postotests/duration/test_arithmetic.py; both fail without the change.tests/durationandtests/intervalpass, and ruff is clean.