Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #607.
pendulum.now(5.5)already returns a datetime at UTC+05:30. Its annotation rejected that call, and theDateTime.nowoverloads also rejected numeric offsets. Both entry points now describe the timezone values accepted at runtime, including fractional hour offsets and standard-librarytzinfoobjects. The class method keeps itsSelfreturn type for subclasses.ZoneInfo.On Windows with
TZ=UTC, the full test suite passed (1,870 passed, 5 skipped). Mypy passed on all 228 source and test files. A separate typed caller covering both entry points and a subclass produced eight diagnostics onmasterand passed with this change.