Repository navigation
Declare minimum Rust version (1.95) and document it - #270
Merged
Merged
Conversation
Bevy 0.19 requires rustc 1.95, but the repo didn't state a minimum Rust version anywhere, so contributors on an older toolchain only found out from a dependency error partway through the build. - Add `rust-version = "1.95"` to `[workspace.package]` and inherit it in every workspace crate, so cargo reports the requirement for our own crates and the MSRV-aware resolver (resolver = "3") can use it. - Note the minimum version and `rustup update stable` in the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
I used Claude's help to create this PR. It didn’t add a rust-toolchain.toml file, claiming that making everyone download one fixed Rust version would be too heavy for a project that builds on latest stable needs. @tychedelia I would appreciate you evaluating whether this is the appropriate solution. Thank you! |
|
Visual regression: 1 changed of 43 cases
If these changes are intentional, add the baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building on Rust 1.94 fails partway through with an error from a dependency:
The repo has no
rust-toolchain.tomland norust-versionin anyCargo.toml, and the README only says to install Rust via rustup. Nothing tells contributors which Rust version they need.Changes
[workspace.package] rust-version = "1.95"to the rootCargo.toml, andrust-version.workspace = trueto every workspace crate (13 crates plus the rootprocessingpackage).rustup update stablefixes an old toolchain.With this, cargo reports our own crates' requirement (
processing_pyo3@0.4.0 requires rustc 1.95, etc.), not only Bevy's. The workspace'sresolver = "3"is MSRV-aware, so it also uses this value when it picks dependency versions.I didn't add a
rust-toolchain.toml. Pinning a toolchain would make rustup download that exact version for everyone, which seems heavier than this project needs while CI tracksstable.Testing
cargo metadatashowsrust_version = 1.95for all 14 packages.just py-buildstill builds on current stable (1.99.1), andanimated_mesh.pyruns.cargo +1.94 check -p processing_pyo3now fails with the requirement listed for the libprocessing crates as well as Bevy's.When Bevy raises its minimum Rust version, update
rust-versionin the rootCargo.tomland the version number in the README.🤖 Generated with Claude Code