Skip to content

Fix ensure default version is set when version is not recognized - #2085

Merged
saundefined merged 1 commit into
php:masterfrom
lufei:fix/download
Nov 19, 2026
Merged

saundefined merged 1 commit into
php:masterfrom
lufei:fix/download

Conversation

@sy-records

Copy link
Copy Markdown
Member
image

Although this was fixed in #2083, it also caused a logical error, resulting in the version not being displayed correctly.

if ($options['os'] === 'osx' || $options['os'] === 'windows') {
if ($options['version'] === 'default') {
$options['version'] = $latestPhpVersion;
}
}

@jordikroon

Copy link
Copy Markdown
Member

@sy-records Not sure if I am missing something. But https://www.php.net/downloads.php?os=osx&osvariant=windows-downloads&version=8.5 seems to be alright? Even if I choose other options.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Regression report for commit 25ee2ef is at https://web-php-regression-report-pr-2085.preview.thephp.foundation

@sy-records

Copy link
Copy Markdown
Member Author

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview for commit 25ee2ef is available at https://web-php-pr-2085.preview.thephp.foundation

@jordikroon

Copy link
Copy Markdown
Member

So only when the version is wrong from the URL. Nice catch and I can confirm it's fixed now. Thank you.

@saundefined
saundefined merged commit c632c85 into php:master Nov 19, 2026
5 checks passed
@sy-records
sy-records deleted the fix/download branch November 19, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants