Repository navigation
Fix ensure default version is set when version is not recognized - #2085
Merged
Merged
Conversation
sy-records
requested review from
derickr,
saundefined and
sgolemon
as code owners
November 19, 2026 03:56
Member
|
@sy-records Not sure if I am missing something. But https://www.php.net/downloads.php?os=osx&osvariant=windows-downloads&version=8.5 seems to be alright? Even if I choose other options. |
Contributor
|
📊 Regression report for commit 25ee2ef is at https://web-php-regression-report-pr-2085.preview.thephp.foundation |
Member
Author
Contributor
|
🚀 Preview for commit 25ee2ef is available at https://web-php-pr-2085.preview.thephp.foundation |
Member
|
So only when the version is wrong from the URL. Nice catch and I can confirm it's fixed now. Thank you. |
jordikroon
approved these changes
Nov 19, 2026
saundefined
approved these changes
Nov 19, 2026
saundefined
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this was fixed in #2083, it also caused a logical error, resulting in the version not being displayed correctly.
web-php/public/downloads-get-instructions.php
Lines 23 to 27 in 55a3d22