Skip to content

Remove stale zh-cn/zh-tw directories from gh-pages - #1303

Merged
itsneufox merged 1 commit into
openmultiplayer:gh-pagesfrom
dockfries:gh-pages-remove-stale-locale-dirs
Nov 18, 2026
Merged

itsneufox merged 1 commit into
openmultiplayer:gh-pagesfrom
dockfries:gh-pages-remove-stale-locale-dirs

Conversation

@dockfries

@dockfries dockfries commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Deletes the stale zh-cn/ and zh-tw/ directories from gh-pages.

They are leftovers from before 425c9ac (March 2025), when I renamed the locale codes to zh-CN/zh-TW. Really sorry I didn't catch this earlier — it's bloating the bundle file size for no reason.

In other words, only zh-CN/ and zh-TW/ should exist on the branch — having all four at once is the bug this PR fixes.

Builds only emit the uppercase directories now, but the deploy action starts each commit from the previous gh-pages tree and runs on macos-latest, whose case-insensitive filesystem prevents rsync --delete from removing case-only paths — so the old directories kept being refreshed instead of deleted.

(JamesIves/github-pages-deploy-action uses rsync internally to sync and clean the deploy directory)

Please merge this before other PRs that trigger a deployment: gh-pages is force-pushed on every master push, so a deployment first would replace this PR's base and make it stale.

After merging, the next deployment is the test — it should come out without zh-cn/ or zh-tw/.

Also, just to note: the previous gh-pages deployment failed (run), but that is unrelated to this PR — it looks like an intermittent issue with upstream's actions/deploy-pages@v5.

@dockfries
dockfries marked this pull request as ready for review November 8, 2026 05:05
@itsneufox
itsneufox merged commit 1e2a0f1 into openmultiplayer:gh-pages Nov 18, 2026
1 check passed
@dockfries
dockfries deleted the gh-pages-remove-stale-locale-dirs branch November 19, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants