Skip to content

chore: update PWA module - #1749

Merged
danielroe merged 1 commit into
nuxt:mainfrom
userquin:update-vite-pwa-nuxt
Nov 21, 2026
Merged

danielroe merged 1 commit into
nuxt:mainfrom
userquin:update-vite-pwa-nuxt

Conversation

@userquin

@userquin userquin commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

NA

📚 Description

This PR updates @vite-pwa/nuxt module (vite-pwa-nuxt):

  • update SVG icon to use a neutral gray (#808080): ~4:1 in light mode and ~4.6:1 in dark mode
  • updated repo entry to point to the packages/module: we've moved the repo to a monorepo (it is now Nuxt Bundler agnostic, we've now a Vite "Bundler" and soon 🤞 Webpack, Rspack and Rsbuild)
  • add Daniel Roe to maintainers ❤️
  • remove twitter handles (we, Anthony and me, canceled the X account)

Nuxt modules using img, and so, we cannot add any style to the SVG, maybe we should add light/dark svg icon support.

Note: to sync the module I've run pnpm sync vite-nuxt-pwa without the repo as second argument after updating the repo entry.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Vite PWA Nuxt module listing changes its description, repository reference, and learn-more URL. Daniel Roe is added as a maintainer with GitHub and Bluesky handles. Twitter handles are removed from the Joaquín Sánchez and Anthony Fu entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to f24ff

This updates the module listing text, links, and maintainer details. It does not change runtime behavior, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title 'chore: update PWA module' refers to a real change in the changeset, since the PR updates the @vite-pwa/nuxt module listing. However, it is generic. It does not say what changed (icon colour…
Description check Passed The description follows the repository template. The linked issue section states NA, which is acceptable because an issue is not required. The description section explains the changes: the SVG icon co…
Full details: Title check

Explanation

The title 'chore: update PWA module' refers to a real change in the changeset, since the PR updates the @vite-pwa/nuxt module listing. However, it is generic. It does not say what changed (icon colour, repository link, maintainer added, Twitter handles removed). The title is partially related and overly broad, so it passes under the stated criteria rather than being inconclusive or failing.

Full details: Description check

Explanation

The description follows the repository template. The linked issue section states NA, which is acceptable because an issue is not required. The description section explains the changes: the SVG icon colour change with contrast ratios, the repository entry update to the monorepo package, the addition of Daniel Roe as maintainer, and the removal of Twitter handles. It also includes a note on the sync command and an observation about icon styling. The template comment block was left in place, which is harmless. The description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a08fcbe9-71ad-4c90-9e16-4104c8454bae
Commits

Reviewing files that changed from the base of the PR and between f94ab77 and f24ffc3.

Files ignored due to path filters: 1

  • icons/vite-pwa-nuxt.svg is excluded by !**/*.svg
Files selected for processing: 1

  • modules/vite-pwa-nuxt.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@danielroe
danielroe merged commit fe86469 into nuxt:main Nov 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants