Repository navigation
fix(examples): build asyncio_reduce image from the pynumaflow root - #392
Open
isaiah-harville wants to merge 1 commit into
Open
isaiah-harville wants to merge 1 commit into
isaiah-harville wants to merge 1 commit into
Conversation
The Dockerfile copies pyproject.toml, uv.lock and pynumaflow/ from the package root, but the Makefile built with the example directory as the context. Docker Publish failed on main with '/pynumaflow: not found' since asyncio_reduce joined the publish matrix. Build from the package root with -f, like the other examples. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: isaiah-harville <harvillerisaiah@gmail.com>
isaiah-harville
requested review from
BulkBeing,
kohlisid and
vigith
as code owners
November 17, 2026 03:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing Docker Publish workflow on
main(run 43249530240).The
examples/reduce/asyncio_reducejob fails with:Its
Dockerfilecopiespyproject.toml,uv.lock,pynumaflow/and the example from the package root. ItsMakefilerandocker buildx build ... .from the example directory, so none of those paths were in the build context. The example joined the publish matrix in 58cb476 and has never built. Every other example's Makefile already doescd ../../../ && docker build -f ${DOCKER_FILE_PATH} .... This change makesasyncio_reducedo the same, and drops the stray quotes aroundIMAGE_REGISTRY.How it was tested
make imageonmainreproduces the CI failure:"/pynumaflow": not found.make imageon this branch builds the image (native arm64, Docker Desktop). Starting Python in the container and importingpynumaflow.reducerandasync_execsucceeds.make -n image-pushrunsdocker buildx build -f examples/reduce/asyncio_reduce/Dockerfile ... .frompackages/pynumaflow.Not run: the multi-arch (amd64 + arm64)
buildxbuild and the push to Quay, which needs credentials. The nextmainpush will confirm the Docker Publish job goes green.🤖 Generated with Claude Code