Skip to content

fix(examples): build asyncio_reduce image from the pynumaflow root - #392

Open
isaiah-harville wants to merge 1 commit into
numaproj:mainfrom
isaiah-harville:fix/asyncio-reduce-docker-build
Open

isaiah-harville wants to merge 1 commit into
numaproj:mainfrom
isaiah-harville:fix/asyncio-reduce-docker-build

Conversation

@isaiah-harville

@isaiah-harville isaiah-harville commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Fixes the failing Docker Publish workflow on main (run 43249530240).

The examples/reduce/asyncio_reduce job fails with:

failed to calculate checksum of ref ...: "/pynumaflow": not found
make: *** [Makefile:11: image-push] Error 1

Its Dockerfile copies pyproject.toml, uv.lock, pynumaflow/ and the example from the package root. Its Makefile ran docker buildx build ... . from the example directory, so none of those paths were in the build context. The example joined the publish matrix in 58cb476 and has never built. Every other example's Makefile already does cd ../../../ && docker build -f ${DOCKER_FILE_PATH} .... This change makes asyncio_reduce do the same, and drops the stray quotes around IMAGE_REGISTRY.

How it was tested

  • make image on main reproduces the CI failure: "/pynumaflow": not found.
  • make image on this branch builds the image (native arm64, Docker Desktop). Starting Python in the container and importing pynumaflow.reducer and async_exec succeeds.
  • make -n image-push runs docker buildx build -f examples/reduce/asyncio_reduce/Dockerfile ... . from packages/pynumaflow.

Not run: the multi-arch (amd64 + arm64) buildx build and the push to Quay, which needs credentials. The next main push will confirm the Docker Publish job goes green.

🤖 Generated with Claude Code

The Dockerfile copies pyproject.toml, uv.lock and pynumaflow/ from the
package root, but the Makefile built with the example directory as the
context. Docker Publish failed on main with '/pynumaflow: not found'
since asyncio_reduce joined the publish matrix. Build from the package
root with -f, like the other examples.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: isaiah-harville <harvillerisaiah@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant