Skip to content

fix(pynumaflow): allow protobuf 7.x and fix stale grpcio pins - #391

Open
isaiah-harville wants to merge 2 commits into
numaproj:mainfrom
isaiah-harville:fix/relax-protobuf-upper-bound
Open

isaiah-harville wants to merge 2 commits into
numaproj:mainfrom
isaiah-harville:fix/relax-protobuf-upper-bound

Conversation

@isaiah-harville

@isaiah-harville isaiah-harville commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Fixes pynumaflow's gRPC and protobuf dependency constraints so it installs alongside current protobuf 7.x projects.

  • Allow protobuf 7.x. protobuf>=6.31.1,<7.0 becomes <8.0. The checked-in 6.31.1 gencode still loads on a 7.x runtime, so nothing is regenerated. The latest grpcio-tools (1.85.1) requires protobuf>=7.35.1, so the old cap blocked it.
  • Raise the grpcio, grpcio-status and grpcio-tools floors from 1.48.1 to 1.74.0. 1.71.x pins protobuf<6, which conflicts with the gencode. 1.74.0 is the first release that accepts protobuf>=6.31.1. This addresses Dependencies pinned incorrectly #332.
  • Move grpcio-tools to the dev group. Only make proto uses it (packages/pynumaflow/Makefile); nothing under pynumaflow/ imports grpc_tools. Users no longer install the protoc toolchain or its protobuf pin. Anyone who relied on it arriving transitively must now install it themselves.

uv.lock is updated to match; locked versions are unchanged.

How it was tested

pytest tests -m "not integration": 341 passed in each of these environments:

  • The locked environment.
  • A fresh environment with protobuf==7.35.1 and no grpcio-tools.

Also checked: with grpcio-tools==1.85.1 installed (resolves to protobuf 7.36.2), import pynumaflow.mapper succeeds.

Not run: integration tests, mypy, pre-commit, make proto with the new toolchain. The dev-only types-protobuf<7 pin is unchanged.

Closes #332

🤖 Generated with Claude Code

Raise the protobuf upper bound from <7.0 to <8.0. The checked-in 6.31.1
gencode imports and the unit suite passes (341 tests) on protobuf 7.35.1,
so the cap only blocks projects that already depend on protobuf 7.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: isaiah-harville <harvillerisaiah@gmail.com>
…ndency

grpcio, grpcio-status and grpcio-tools were allowed back to 1.48.1, but
1.71.x pins protobuf<6, which conflicts with the 6.31.1 gencode. 1.74.0
is the first release that accepts protobuf>=6.31.1.

grpcio-tools is only used by 'make proto', so move it to the dev group
instead of shipping its protobuf pin to every user.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: isaiah-harville <harvillerisaiah@gmail.com>
@isaiah-harville isaiah-harville changed the title fix(pynumaflow): allow protobuf 7.x fix(pynumaflow): allow protobuf 7.x and fix stale grpcio pins Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependencies pinned incorrectly

1 participant