Repository navigation
Improve object safety #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vladimir Morozov (vmoroz)
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
vmoroz:PR/improve-object-safety
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| namespace Microsoft.JavaScript.NodeApi.DotNetHost; | ||
|
|
||
| /// <summary> | ||
| /// Native handshake structure the managed host fills in at initialization, so the native host can | ||
| /// keep the managed host alive for the environment lifetime and notify it when the environment is | ||
| /// torn down. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// The layout must exactly match the native host's own copy of this structure (in the NodeApi | ||
| /// assembly). Both are two pointer-sized fields, passed by pointer across the native/managed | ||
| /// boundary. The native host and managed host run in separate .NET runtimes, so the structure is | ||
| /// defined independently in each and only its binary layout is shared. | ||
| /// </remarks> | ||
| [StructLayout(LayoutKind.Sequential)] | ||
| internal struct ManagedHostRegistration | ||
| { | ||
| /// <summary> | ||
| /// A strong <see cref="GCHandle"/> to the managed host, allocated and freed only by managed | ||
| /// code. The native host treats it as an opaque pointer. | ||
| /// </summary> | ||
| public nint AddonGCHandle; | ||
|
|
||
| /// <summary> | ||
| /// A native callback pointer (<c>delegate* unmanaged<nint, void></c>) the native host | ||
| /// invokes at environment teardown, or default when the native host uses another channel | ||
| /// (the .NET Framework host invokes the finalize method through the default AppDomain instead). | ||
| /// </summary> | ||
| public nint OnEnvFinalize; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.