Repository navigation
Preserve glob range negation and path boundaries - #65477
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Jake Bailey (jakebailey) wants to merge 1 commit into
Conversation
Honor negated character ranges when matching and rendering patterns. Keep separators available after star matches and stop consuming slashes before indexing an exhausted input.
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the glob matcher changes.
No open issues 🎉
What changed in this PR
This PR fixes range negation and path-boundary handling in the native TypeScript compiler’s vendored glob matcher.
Changes:
- Preserve negated character ranges when formatting and matching patterns.
- Keep path separators available after
*matches and prevent out-of-bounds access when consuming trailing slashes. - Add regression tests for negated ranges, Unicode, wildcard boundaries, and trailing separators.
| File | Description |
|---|---|
tsc/internal/glob/glob.go |
Corrects range negation, wildcard boundaries, and slash handling. |
tsc/internal/glob/glob_test.go |
Adds formatting and matching regression tests. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is vendored from gopls, but sadly it's also buggy.
Caught in an audit.