Repository navigation
Conversation
- The REST variable data endpoints validate the type of the variable before resolving its value. With the default configuration (serializable variables disabled in the engine and not allowed in the REST API) they return a 415 response instead of a 500 response, and no serializable variable is deserialized before the request is rejected. - A variable with a JSON object or array as value and no type is rejected with a 400 response in the REST API, since such a value could only be stored using Java serialization. The json type needs to be used instead. This does not apply to transient variables. - The old value of a variable is only read when a logging session is enabled. This allows overwriting an existing serializable variable with a value of another type when serializable variables are disabled. The logging session no longer reads the value of a serializable variable that cannot be read, such a variable is logged without its value. - The Drools based business rule task logs a warning when its result is only stored as a transient variable. - Restore the API responses documentation of the historic process and case instance variable data endpoints. - Add tests for the serializable variable type mode in the CMMN and v5 engines, for the default configuration of the REST API, for the string only filter of the JPA entity list variable type and for float variables in the CMMN and v5 engines.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to "Disable serializable variables by default" (1c9e84d), addressing findings from reviewing that change.
Changes
415response instead of a500response, and no serializable variable is deserialized before the request is rejected. This applies to all data endpoints inflowable-restandflowable-cmmn-rest.400response, since such a value could only be stored using Java serialization. Thejsontype needs to be used instead. This applies to the BPMN, CMMN and external job REST APIs. Transient variables are not affected.@ApiResponsesof the historic process and case instance variable data endpoints.Behavior changes to be aware of
ENABLED.DISABLEDmode an existing serializable variable can be overwritten with a value of another type (this failed before).Tests
SerializableVariablesDefaultConfigurationTestinflowable-restandflowable-cmmn-rest: no property set and aDISABLEDengine, covering create, every data endpoint and untyped JSON values.SerializableVariableTypeModeTestfor the CMMN engine and the v5 engine, and new cases for the BPMN engine (overwrite inDISABLED, overwrite and remove with a logging session).JPAEntityListVariableType.FloatVariableTestfor the CMMN engine, float variable test for the v5 engine.