Repository navigation
Push apps: Settings → Push Apps, and pushes with each app's own keys - #436
Merged
Merged
Conversation
…h their own keys - Settings → Push Apps lists, adds, edits and removes the organization's push apps (APNs key and Firebase service account, written but never read back) and sends a test push to one device. - v1/customers/register-device and v1/drivers/register-device accept push_app (the app's key) and environment, link the device to that app and refuse an unknown key. - Every Fleet-Ops push notification also goes through core's PushAppChannel; Driver and Contact route push-app devices there and every other device to the install-wide APNs and FCM channels as before. - Requires fleetbase/core-api ^2.0.3.
Merged
- composer accepts dev-release/v2.0.3 next to ^2.0.3, and the contract run links core-api's release branch - the service account placeholder no longer has braces, which ICU read as an argument and failed the Ember build - install-wide token routes are plain lists, and the tests now expect that
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An organization's own apps (Passenger, a white-label driver app, an AppHelm build) now get Fleet-Ops pushes sent with their own Apple and Firebase credentials. The registry is core's
PushApp(fleetbase/core-api#340); this adds the Fleet-Ops side.fleet-ops/settings/push-apps, permissionsview/update notification-settings): add, edit, turn off and remove push apps. Each has its key to copy into the app, its iOS bundle and Android project, and a device count. Keys are pasted in and never shown again; leaving one empty when editing keeps it. Send test push checks an app against one device token.v1/customers/register-deviceandv1/drivers/register-deviceacceptpush_app(the key) andenvironment(production/sandbox). The device is linked to the app (PushAppDevices); a key that isn't one of the organization's active apps is refused.OrderUpdate, used by order confignotify_customer/notify_driver, plus assigned, dispatched, canceled, completed, failed, changed, unassigned, ping, waypoint completed) addPushAppChannel.DriverandContactroute push-app devices to it and all other devices to the install-wide APNs/FCM channels, so Navigator and existing devices are unchanged and nothing is sent twice.composer.jsonrequiresfleetbase/core-api^2.0.3, so CI here stays red until core-api 2.0.3 (Release v2.0.3 core-api#339) is released.Tests:
server/tests/Unit/Support/PushAppsTest.phpcovers routing, device linking and every Settings endpoint branch; register-device tests cover the refused key.