Repository navigation
Revive AvmcIfc test server - Enable dead tests on CI. - #998
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
+ Coverage 91.84% 91.91% +0.06%
==========================================
Files 150 150
Lines 15668 15674 +6
==========================================
+ Hits 14390 14406 +16
+ Misses 1278 1268 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #572
Summary
This PR moves the AvmcIfc test server sources and pre-built DLLs to a dedicated directory, adds CI steps to register/unregister the server, and makes tests skip gracefully when the server is not available.
This enables previously dead tests to run on GitHub Actions CI.
Why
Some tests require the
AvmcIfcCOM server to be registered.For a long time, these tests were skipped or failed on CI because the DLL was not registered.
This made it impossible to verify that the code works correctly.
This PR:
source/tosource/Avmc/(including pre-built DLLs)AvmcIfc.dllandAvmcIfc_x64.dlltest_avmc.pyto skip tests cleanly when the type library is not registeredAbout the AvmcIfc test server
The
AvmcIfcinproc server is a simple test double implemented insource/Avmc/Avmc.cppandsource/Avmc/AvmcIfc.cpp. It:IAvmcwith one methodFindAllAvmcSAFEARRAYofDeviceInfostructures (VT_RECORD)VT_ARRAY | VT_RECORDmarshaling in comtypesWhat this PR does NOT do
source/not incomtypes/. TheMANIFEST.inandpyproject.tomldo not include them.register_server()for local development - The function incomtypes/test/__init__.pystill expects the DLL atsource/Avmc/Debug/. Local developers must build it themselves or get it from CI artifacts.Test impact
Tests that were previously skipped or failed due to missing
AvmcIfcwill now run on CI:test_avmc.py(now skips cleanly if not registered, runs if registered)Out of scope
AvmcIfc.dllfrom source in CI (separate PR)register_server()work without pre-built DLLs (separate PR)