Repository navigation
Conversation
…ration and stub Commit 2e155d6 ("drivers: hv: tear down the Xen VMBus interrupt bridge on unwind") added hyperv_remove_xen_vmbus_irq() to the x86 copy of the nested-on-Xen block in asm/mshyperv.h only. The asm-generic copy that other architectures use, arm64 among them, neither declares it nor stubs it, and vmbus_drv.c calls it unconditionally, so an arm64 kernel with CONFIG_HYPERV fails to compile. The nightly arm64 build does not enable HYPERV, which is why it did not catch this. Add the declaration and the empty stub to the asm-generic block, next to hyperv_setup_xen_vmbus_irq(), so the two copies match again. Signed-off-by: Ariadne Conill <ariadne@ariadne.space>
kaniini
requested review from
antoineco,
azenla,
bleggett,
sveith and
tycho
as code owners
November 13, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VMBus interrupt bridge teardown added in 2e155d6 declared
hyperv_remove_xen_vmbus_irq()in the x86 copy of the nested-on-Xen block only. The asm-generic copy, which arm64 uses, has neither the declaration nor the stub, andvmbus_drv.ccalls the function unconditionally, so an arm64 kernel withCONFIG_HYPERVdoes not compile. The nightly arm64 build does not enable HYPERV, which is why CI did not catch it.This adds the declaration and the empty stub to the asm-generic block next to
hyperv_setup_xen_vmbus_irq(), so the two copies match again.Verified with
make LLVM=1 ARCH=arm64 defconfigplusHYPERVandHYPERV_VMBUSenabled:drivers/hv/vmbus_drv.ofails onedera/mainlinewith the two "call to undeclared function" errors from the issue and builds cleanly with this change.ENG-223