Repository navigation
feat(offload): build for every distro except static - #604
Open
nicksieger wants to merge 1 commit into
Open
nicksieger wants to merge 1 commit into
nicksieger wants to merge 1 commit into
Conversation
Derive the offload distro list from DISTROS instead of a fixed subset. static stays excluded: the offload Dockerfile has no builder-static stage. Signed-off-by: Nick Sieger <nick@nicksieger.com>
vvoland
reviewed
Nov 19, 2026
| offload = ["ubuntu2404", "ubuntu2604", "rockylinux8"] | ||
| # Every distro except static: the offload Dockerfile has no builder-static stage. | ||
| offload = [for distro in DISTROS : distro if distro != "static"] | ||
| } |
Collaborator
There was a problem hiding this comment.
I think this would be simpler if we just get #603 in first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offload was limited to
ubuntu2404,ubuntu2604androckylinux8. It now builds for every distro inDISTROSexceptstatic, which is 23 distros, each onlinux/amd64andlinux/arm64.PKG_DISTROS.offloadis derived fromDISTROSrather than listed again, soDISTROSstays the single source and a distro added there is picked up by Offload.staticstays excluded because the Offload Dockerfile has nobuilder-staticstage. A change that adds one has to drop that filter.The per-package list can be read from bake.
pkg-offload-<distro>is one target per distro, with the distro fields inargs:override.hclhas to setPKGS_EXTRA = ["offload"], because Offload is not inPKGS_BASE.Checked with
bake --printonly: 23pkgand 23verifytargets resolve. The builds were not run, so these are untested:rhel*targets use the UBI images and declare theRH_USERandRH_PASSsecrets. They should build without a subscription, since the package needs onlybashandmake.ubuntu:stonkingandfedora:45images may not be published yet.debian12,ubuntu2204, the el8 family) is unchecked. Go comes from the golang image and the binary does not link the distro libc, so a problem is not expected.🤖 Generated with Claude Code