Skip to content

feat(offload): build for every distro except static - #604

Open
nicksieger wants to merge 1 commit into
docker:mainfrom
nicksieger:offload-all-distros
Open

nicksieger wants to merge 1 commit into
docker:mainfrom
nicksieger:offload-all-distros

Conversation

@nicksieger

Copy link
Copy Markdown
Member

Offload was limited to ubuntu2404, ubuntu2604 and rockylinux8. It now builds for every distro in DISTROS except static, which is 23 distros, each on linux/amd64 and linux/arm64.

PKG_DISTROS.offload is derived from DISTROS rather than listed again, so DISTROS stays the single source and a distro added there is picked up by Offload. static stays excluded because the Offload Dockerfile has no builder-static stage. A change that adds one has to drop that filter.

The per-package list can be read from bake. pkg-offload-<distro> is one target per distro, with the distro fields in args:

$ docker buildx bake -f docker-bake.hcl -f override.hcl --print pkg 2>/dev/null \
    | jq -c '[.target | to_entries[] | select(.key | startswith("pkg-offload-")) | .value.args | {name: .DISTRO_NAME, type: .DISTRO_TYPE, release: .DISTRO_RELEASE, id: .DISTRO_ID, suite: .DISTRO_SUITE}] | sort_by(.name)'
[{"name":"almalinux10", ...},{"name":"debian12","type":"deb","release":"debian","id":"12","suite":"bookworm"}, ...]

override.hcl has to set PKGS_EXTRA = ["offload"], because Offload is not in PKGS_BASE.

Checked with bake --print only: 23 pkg and 23 verify targets resolve. The builds were not run, so these are untested:

  • The rhel* targets use the UBI images and declare the RH_USER and RH_PASS secrets. They should build without a subscription, since the package needs only bash and make.
  • The ubuntu:stonking and fedora:45 images may not be published yet.
  • Whether the pinned Go version builds the plugin on the oldest distros (debian12, ubuntu2204, the el8 family) is unchecked. Go comes from the golang image and the binary does not link the distro libc, so a problem is not expected.

🤖 Generated with Claude Code

Derive the offload distro list from DISTROS instead of a fixed subset.
static stays excluded: the offload Dockerfile has no builder-static stage.

Signed-off-by: Nick Sieger <nick@nicksieger.com>
@nicksieger
nicksieger requested a review from a team as a code owner November 19, 2026 21:41
Comment thread docker-bake.hcl
offload = ["ubuntu2404", "ubuntu2604", "rockylinux8"]
# Every distro except static: the offload Dockerfile has no builder-static stage.
offload = [for distro in DISTROS : distro if distro != "static"]
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be simpler if we just get #603 in first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants