Repository navigation
Conversation
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 3 tests: regression=0 unreleased=3 coverage=0 failing=0
TestAccept/air/image-push: branch ✅ | main (4c8b7a1) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/cmd/aitools/claude-config-dir: branch ✅ | main (4c8b7a1) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/cmd/aitools/telemetry/hint: branch ✅ | main (4c8b7a1) ✅ | latest (v1.26.0) ❌latest (v1.26.0): |
✅ Integration test reportCommit: 193c480
Top 3 slowest tests (at least 2 minutes):
|
simonfaltum
left a comment
There was a problem hiding this comment.
🤖 Automated review from simonfaltum's review agent (pr-review skill) at 0486b26. Each finding was verified against the code; simonfaltum may follow up.
Not approving yet: 1 blocking issue(s), tagged [blocking].
This PR moves the CI / CI/CD-provider unset line, which was copied into three acceptance scripts, into a shared unset_ci_env helper in the root script.prepare. The helper commit itself is correct and follows the repo's conventions: its variable list matches listCiCdProviders in the pinned SDK, and the root prepare file is the right home for it. However, the branch still contains an older, pre-review revision of #7585 rather than the merged one, so it conflicts with main and its diff drags in stale #7585 code. Resolving those conflicts toward the branch would revert merged fixes, such as accepting CI=no/off. Please rebase so that only the helper commit sits on main, and refresh the description; note that #7692 edits the same three scripts.
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // hintEnvVars are the non-detection env vars MaybeHint reads. They are cleared |
There was a problem hiding this comment.
[blocking] This branch is built on 07a831d, an older revision of #7585 from before its review feedback, not on the squash-merged #7585 (10fe968). GitHub reports the PR as not mergeable, with conflicts in six files: .nextchanges/cli/claude-code-native-hint.md, the three acceptance scripts, hint.go and hint_test.go. The PR diff also shows 21 files instead of the 5 the helper touches. If a conflict is resolved toward this branch, merged #7585 fixes come back undone. For example, inCI would go back to strconv.ParseBool, so CI=no or CI=off would count as CI again and drop the native hint. Also returning: hintEnvVars/unsetEnv (main now relies on testutil.SetAgentEnv clearing the env), the inline closure in place of the shared noRecordedPlugin, the extra plugin-manifest read, and the older .nextchanges entry. The description is also stale: #7585 is already merged, and main has no hintEnvVars, so after a rebase unset_ci_env is the only copy of the list. Please rebase with git rebase --onto origin/main 07a831d8a, which keeps only 0486b26 (it applies cleanly), and update the description.
Three acceptance scripts unset the same list of CI and CI/CD provider variables so the native Claude Code hint line also prints in CI. Move the list into one unset_ci_env helper in the root script.prepare, the only prepare file that covers both cmd/aitools and air, with a pointer to the SDK's useragent/cicd.go so it stays in sync. Co-authored-by: Isaac <no-reply@databricks.com>
0486b26 to
193c480
Compare
Changes
Adds an
unset_ci_envhelper toacceptance/script.prepare. It replaces the copies of the CI and CI/CD providerunsetline incmd/aitools/claude-config-dir,cmd/aitools/telemetry/hintandair/image-push. The helper's comment points atlistCiCdProvidersin the Go SDK'suseragent/cicd.goso the list stays in sync. The helper is also listed in the built-in helpers section of.agents/rules/testing.md.Stacked on #7585.
Why
Addresses simonfaltum's review comment on #7585 about the duplicated line. Only the root
script.preparecovers bothcmd/aitoolsandair, so the helper lives there. The Go-side copy (hintEnvVarsinlibs/aitools/agents/hint_test.go) is left as is.Tests
go test ./acceptance -run 'TestAccept/cmd/aitools|TestAccept/air'passes with no golden changes, both in a clean env and withCI=true GITHUB_ACTIONS=trueexported. The native hint lines still match../task wsand./task checkspass.This pull request and its description were written by Isaac.