Skip to content

fix(ui): keep the top panel one height at 1024 px, tidy the actions menu block - #106

Merged
daggerok merged 1 commit into
mainfrom
fix/top-panel-tidy
Nov 15, 2026
Merged

daggerok merged 1 commit into
mainfrom
fix/top-panel-tidy

Conversation

@daggerok

Copy link
Copy Markdown
Owner

What changed

  • Between lg and xl the selected detail tabs (#selected-tabs-bar) drop their counts and the bar hides its scrollbar (wheel, touch and keyboard focus still scroll it)
  • Between lg and xl the title column of the first panel is at least as wide as icon + title, so a long brand name is never clipped by the 11rem floor
  • The actions menu block in src/main.tsx is byte-identical to the ui-std block actions-menu.tsx again (blank line after every line removed, no behaviour change)

Why

At 1024 px with every fund selected the first panel grew 60 -> 71 px (scrollbar on the tabs bar, clipped title). Ported by ui-std top-panel-tidy.ts (workspace tracker S32 and S33), same as Schwab PR 93

How it was checked

1024 px, every fund selected (subcheck.ts)

  • before: {"hb":60,"ha":71,"bar":[629,595,11],"title":[204,176],"bad":["nav height 60 -> 71","title cell clipped after (scrollWidth 204 > clientWidth 176)"]}
  • after: {"hb":60,"ha":60,"bar":[476,476,0],"title":[213,213],"bad":[]}

actions-menu-gates.sh, last line ALL GATES PASSED WisdomTree:

ok   install
ok   test
ok   build-updater
ok   build-main
ok   build
ok   diff-check
ok   tc
ok   menu
     35 passed, 0 failed; console errors: none
ok   brand
     43 passed, 0 failed; console errors: none
ok   columns
     19 passed, 0 failed; console errors: none
ok   categories
     19 passed, 0 failed; console errors: none
ok   clear
     19 passed, 0 failed; console errors: none
ok   security
     20 passed, 0 failed; console errors: none
ok   pcheck
ok   subcheck
ALL GATES PASSED WisdomTree

subassert.ts on the after run: PASS

…enu block

- Between lg and xl the selected detail tabs drop their counts and the
  tabs bar hides its scrollbar (it still scrolls by wheel, touch and
  focus), so the first panel stays 60 px instead of growing to 71 px
- Between lg and xl the title column is at least as wide as icon + title,
  so a long brand name is never clipped
- The actions menu block in main.tsx is byte-identical to the ui-std
  block again (the first port double-spaced it)
@daggerok
daggerok merged commit d9cc3b1 into main Nov 15, 2026
@daggerok
daggerok deleted the fix/top-panel-tidy branch November 15, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant