Repository navigation
fix(ui): keep the top panel one height at 1024 px, tidy the actions menu block - #106
Merged
Merged
Conversation
…enu block - Between lg and xl the selected detail tabs drop their counts and the tabs bar hides its scrollbar (it still scrolls by wheel, touch and focus), so the first panel stays 60 px instead of growing to 71 px - Between lg and xl the title column is at least as wide as icon + title, so a long brand name is never clipped - The actions menu block in main.tsx is byte-identical to the ui-std block again (the first port double-spaced it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lgandxlthe selected detail tabs (#selected-tabs-bar) drop their counts and the bar hides its scrollbar (wheel, touch and keyboard focus still scroll it)lgandxlthe title column of the first panel is at least as wide as icon + title, so a long brand name is never clipped by the 11rem floorsrc/main.tsxis byte-identical to the ui-std blockactions-menu.tsxagain (blank line after every line removed, no behaviour change)Why
At 1024 px with every fund selected the first panel grew 60 -> 71 px (scrollbar on the tabs bar, clipped title). Ported by ui-std
top-panel-tidy.ts(workspace tracker S32 and S33), same as Schwab PR 93How it was checked
1024 px, every fund selected (subcheck.ts)
{"hb":60,"ha":71,"bar":[629,595,11],"title":[204,176],"bad":["nav height 60 -> 71","title cell clipped after (scrollWidth 204 > clientWidth 176)"]}{"hb":60,"ha":60,"bar":[476,476,0],"title":[213,213],"bad":[]}actions-menu-gates.sh, last lineALL GATES PASSED WisdomTree:subassert.tson the after run: PASS