Repository navigation
Fix #15221 (Deprecate the clang import) #9031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2dca7ef
d56db03
72e1f8b
c5bef91
97a960c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
|
|
||
| Release Notes for Cppcheck 2.23 | ||
|
|
||
| Options: | ||
| - Rules: The PCRE library that we used is end-of-life. We have switched to PCRE2 instead. Existing rule files | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AI review This adds a second PCRE2 entry under "Options", which duplicates the one under "Infrastructure & dependencies". It also changes that existing entry from "Existing rule patterns and rule files work unchanged" to "will hopefully work". Neither change is related to the clang import deprecation, so it should probably go into a separate PR or be dropped. |
||
| will hopefully work without changes. | ||
| - The --clang option has been deprecated, it will be removed in Cppcheck 2.27 | ||
|
|
||
| Major bug fixes & crashes: | ||
| - | ||
|
|
||
|
|
@@ -22,8 +27,8 @@ Import project: | |
| Infrastructure & dependencies: | ||
| - Added arm64 platform files arm64-windows.xml, arm64-linux.xml and arm64-macos.xml (Apple Silicon). | ||
| These describe the default setup for that OS. The arm64-wchar_t2.xml and arm64-wchar_t4.xml files are kept. | ||
| - The rules feature (HAVE_RULES) now uses PCRE2 instead of the discontinued PCRE library. Existing rule patterns | ||
| and rule files work unchanged. On Windows the Visual Studio project now expects pcre2-8.lib and pcre2.h in externals. | ||
| - The rules feature (HAVE_RULES) now uses PCRE2 instead of the discontinued PCRE library. On Windows the | ||
| Visual Studio project now expects pcre2-8.lib and pcre2.h in externals. | ||
|
|
||
| Other: | ||
| - | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI review
The notice goes through
mErrorLogger.reportErr, so it is handled like any other finding.cppcheck --clang --error-exitcode=1 -q a.con a file without any issues now returns 1 (it returned 0 before). Every CI job that uses--clangwith--error-exitcodewill start failing.The notice is also emitted once per checked file (and per run with
--cppcheck-build-dir). For empty files it comes with an empty code snippet, and it shows up in xml/sarif results as an<error id="clangimport">.A one-time warning printed in
CmdLineParserwhen--clang(or a project with<parser>clang</parser>) is used would avoid all of this, e.g.mLogger.printMessage("'--clang' is deprecated and will be removed in Cppcheck 2.27."). If you keep it as an ErrorMessage, it should at least not affect the exit code, and the id should appear in--errorlist.