Repository navigation
Conversation
TableBlockParser accepted a table when the delimiter row had at least as many cells as the header row. The GFM spec requires the counts to match: "The header row must match the delimiter row in the number of cells. If not, a table will not be recognized", and cmark-gfm enforces strict equality (header_row->n_columns != delimiter_row->n_columns rejects the table). For example, the following was parsed as a table and now stays a paragraph: Abc|Def ---|-|- 1|2 Signed-off-by: simpleqt <2015900818@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject GFM tables where the delimiter row has more cells than the header
TableBlockParseraccepted a table when the delimiter row had at least as many cells as the header row. The GFM spec requires the counts to match ("The header row must match the delimiter row in the number of cells. If not, a table will not be recognized"), and cmark-gfm enforces strict equality. For example, this was parsed as a table and now stays a paragraph:The existing test only covered the delimiter row having fewer cells; this adds the missing more-cells direction (
separatorMustNotHaveMorePartsThanHead). All 78 tables-module tests and the 2302 core-module tests pass.