[neznaika0]

Description

• Enabled all PHPStan rules at level 5
• cs-fixer allows $this for PHPUnit static methods; PHPStan now ignores them
• @phpstan-* prefixes are irrelevant since the project relies entirely on PHPStan
• Constructor property promotion changed: null has no meaning and properties should always have a value. Previously null was used for convenience of object initialization
• NothingPersonalValidator::isNotPersonal() is now more precise
• EmailConfig values have long been strings; (string) cast is no longer relevant
• $credentials filtering: let us know if all empty values (0, '0', 0.0...) need to be checked
• Updated code examples in docs/

If you approve these changes, I have more fixes for NothingPersonalValidator coming up.
Going forward, I can update the errors from the PHPStan baseline.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

Rebased.
But I left the properties without null; they should be present in all cases.

And console output:

 [WARNING] These rules are registered in both sets and "withRules()". Remove them from "withRules()" to avoid           
           duplications:                                                                                                
                                                                                                                        
           * Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector *                              
           Rector\PHPUnit\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector *                        
           Rector\PHPUnit\PHPUnit120\Rector\Class_\PropertyCreateMockToCreateStubRector *                               
           Rector\PHPUnit\PHPUnit120\Rector\Property\MockObjectVarToStubRector *                                        
           Rector\PHPUnit\CodeQuality\Rector\Class_\AddStubIntersectionVarToStubPropertyRector *                        
           Rector\PHPUnit\CodeQuality\Rector\ClassMethod\BareCreateMockAssignToDirectUseRector *                        
           Rector\PHPUnit\CodeQuality\Rector\MethodCall\RemoveExpectAnyFromMockRector *                                 
           Rector\PHPUnit\PHPUnit60\Rector\MethodCall\GetMockBuilderGetMockToCreateMockRector

[neznaika0]

The analyzer didn’t complain about JWSDecoder class, but it was also modified in the previous PR. Do we need to update it here?

-   private JWSAdapterInterface $jwsAdapter;

    /**
     * @var string The key group. The array key of Config\AuthJWT::$keys.
     */
    protected $keyset = 'default';

-    public function __construct(?JWSAdapterInterface $jwsAdapter = null)
+    public function __construct(private ?JWSAdapterInterface $jwsAdapter = null)
    {

[michalsn]

I guess we should.

[neznaika0]

Coveralls fixed in next PR