Repository navigation
Conversation
The portal's Genomic Evolution table ends its default columns with Cohort, as the patient mutation table does. Each evolution row now carries the study counts the Summary table's Cohort cell draws: samples with a called mutation in the gene, those with the row's keyword, and those whose panel covers the gene. Its Cohort % is blank without a keyword, as the portal's. The cell is the same FrequencyBar and tooltip. One source for both tables: - SQL (lib/patient-alterations.ts): mutationCohortCtes, MUTATION_COHORT_JOIN, MUTATION_FREQ, MUTATION_COHORT_COUNTS and cohortOf, extracted verbatim, so the Summary table's statements are unchanged. - The cell: app/lab/cohort-cell.tsx, moved out of alterations-body. - The caveat and method record say how the % is computed. Checked on the fixture (scripts/check-evolution-annotation.ts, now 14 checks): FX-P02 KRAS G12D is 24 of 59 samples, 16 with "KRAS G12 missense", 40.68%, as counted by hand from data_mutations.txt and the panel matrix. Every FX-P01 and FX-P02 row's counts and % equal the Summary table's. On lgg_ucsf_2014 P04, the rows both pages show have identical tooltips (TP53 R248Q "55 samples (90%) … 4 (7%) have TP53 R248 missense mutations"). The evolution snapshot was re-recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3ezTVY3MHJRLp4DsZ9c7C
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PTB-GE-TB-1, part 3: the Genomic Evolution table gets the portal's Cohort column, last of its defaults, as in the patient mutation table.
mutationCohortCtes,MUTATION_COHORT_JOIN,MUTATION_FREQ,MUTATION_COHORT_COUNTSandcohortOfare now exported fromlib/patient-alterations.ts. They were extracted verbatim, so the Summary table's statements are byte-identical and its snapshots unchanged.alterations-body.tsxintoapp/lab/cohort-cell.tsx.cohort-pct-no-keyword-shown,cohort-detail-keyword-count-is-gene-count) follow their moved sites and are still caught, checked by hand.Checked
scripts/check-evolution-annotation.tsnow has 14 checks.data_mutations.txtand the panel matrix: both panels cover KRAS; G12C/D/V are 16 samples.evolutionre-recorded.test/view-evolution.test.ts: the source uses the Patient tables' CTEs, join and %, with Cohort last.evolution-cohort-no-keyword(guardevolution-annotation): applied by hand, it fails C1 and C2; the file was restored.Tracker
docs/legacy-spec/parity/41-patient-tabs.mddocs/PORTAL-PARITY.md, in "High — daily-use features, data already loaded", item**Patient → Genomic Evolution**, under its sub-itemTable: Annotation, Allele Freq bars and Cohort columns; the portal's page size (ours 25) (PTB-TB-1)(still[ ]), beside #488's line, add:🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3ezTVY3MHJRLp4DsZ9c7C
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.