Repository navigation
Conversation
…re is hovered (ONC-LY-2) The portal gives every track a menu-dots button between its label and its info (oncoprintjs oncoprinttrackoptionsview renderTrackOptions), hidden until the oncoprint is hovered (oncoprintStyles.scss: opacity 0, 1 under :hover); a click toggles the track's menu. Ours opened the menu only from a click on the label. Each row now has an HTML ⋮ button (aria-label "Track options: <name>") over the gutter, left of the row's % or of the gutter's edge (canvas.ts menuButtonX, GEOM.menuW 14). It opens the same track menu under itself and closes it on a second click; hidden at rest, shown while the figure is hovered, the button focused or its menu open. On screen the OQL line stops before it (draw's menuButtons); an export draws no buttons and keeps the room. A click on the label still opens the menu. Tests: test/oncoprint-track-button.test.ts B1-B3 from the legacy sources. Planted bugs: scripts/mutants/oncoprint/track-menu-button.ts (2), each caught by hand. npm test 7173/0, lint clean. Browser (coadread KRAS TP53): five buttons, hidden at rest, shown on hover; KRAS's opens KRAS's menu under it, a second click closes it; no console errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3ezTZqTUJJDrEaiCKckHz
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each OncoPrint track now has a ⋮ button that opens its menu, as in the portal (ONC-LY-2, the rest of it).
The portal puts a menu-dots button on every track, between the label and the track info (oncoprintjs
oncoprinttrackoptionsview.tsrenderTrackOptions355-400). The buttons are hidden until the oncoprint is hovered (src/globalStyles/oncoprintStyles.scss1-20: opacity 0, then 1 under:hover). A click toggles the track's menu (showTrackMenu/hideTrackMenu128-145). Ours opened the menu only from a click on the label.app/_oncoprint/canvas.tsmenuButtonX,GEOM.menuW14 px).app/globals.css.onco-trackbtn).draw'smenuButtons). An export draws no buttons and keeps the full width.Spec IDs
Covered: ONC-LY-2 (with #480's label cut).
Ours alone: a click on the label opens the menu too.
Verification
test/oncoprint-track-button.test.tsB1-B3, from the legacy sources above.npm test7173 pass, 0 fail. Lint is clean.KRAS TP53):scripts/mutants/oncoprint/track-menu-button.tshas 2 (the button over the %; the OQL line running under the button). Each is caught by hand, and all 748 sites are found once.Tracker
PORTAL-PARITY, under Results → OncoPrint, the default view, replace the line as #480 and #485 leave it,
with
Scorecard
01-oncoprint.mdrow:| ONC-LY-2 | ✅ | B | label | ⋮ | info | cells: labels cut as the portal's (#480); each track's ⋮, shown while the figure is hovered, opens its menu (#499) |
Preview
Results → OncoPrint: hover the figure; each row shows ⋮ in the gutter, and clicking one opens that row's menu.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3ezTZqTUJJDrEaiCKckHz
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.