Repository navigation
Conversation
…row, value or interval per pill (STV-FB-3 #13, #14) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3ezTaCo6wHFVsML6Qd4ht
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The filter bar now names a generic-assay filter by its chart, as the portal does: " : or ", each pill removable (STV-FB-3 #13, #14;
UserSelectionsgenericAssaySelectionFilters / genericAssayDataFilters). Before, these were the generic clause pills.Spec IDs
Verification
Browser, dev server, coadread: the arm-level CNA frequency table, 18p Loss and 17p Loss applied.
Unit tests:
test/study-view-pills.test.ts, "generic-assay pills":npm test7,196 pass, 0 fail;tsc --noEmitand eslint clean.Coverage: passes.
Planted bugs: 4 in
scripts/mutants/study-view/assay-pills.ts(guardunit).Tracker
Under "Study View → filters, actions and tabs", this line (docs/PORTAL-PARITY.md:483, as #489 left it):
becomes:
Scorecard
31-study-view-shell.md, row STV-FB-3 (as #489 left it:| STV-FB-3 | 🟡 | B | Clinical (incl. NA) named by the chart's display name, a pill per value or range; gene-table selections a pill per gene coloured by alteration (geneTablePills); gene-chart and mutation-type filters "<chart> : <state> or <state>", each removable (geneStatesFilter); GA, case-list, event and derived clauses still the generic pills; no group-filter or treatment pills |):| STV-FB-3 | 🟡 | B | Clinical (incl. NA) named by the chart's display name, a pill per value or range; gene-table selections a pill per gene coloured by alteration (
geneTablePills); gene-chart and mutation-type filters " : or ", each removable (geneStatesFilter); generic-assay frequency-table rows, values and intervals by their chart, each removable, intervals editable; case-list, event and derived clauses still the generic pills; no group-filter or treatment pills |Preview
/lab?tab=explore&study=coadread_tcga_pan_can_atlas_2018: in the arm-level CNA frequency table, check two rows and Apply filter.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3ezTaCo6wHFVsML6Qd4ht
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.