Repository navigation
Conversation
…load ▸ Data (STS-OT-6)
- Union or Intersection for two or more checked rows, as the gene tables (STS-GT-9): Intersection
is a clause per row, every one held; past the selection's filter limit it is refused, naming it.
- Each table's ⓘ with the portal's description ("List of treatments and the corresponding number
of patients treated", "… samples acquired before treatment or after/on treatment").
- Download ▸ Data: "Treatment\t#" and "Treatment\tPre/Post\t#", as the portal's
getPatientTreatmentDownloadData / getSampleTreatmentDownloadData, in the rows' order shown.
Seen on coadread: Fluorouracil and Leucovorin, Intersection, 135 patients, the portal's
/filtered-samples count for that patientTreatmentFilters.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q3ezTaCo6wHFVsML6Qd4ht
…-extras # Conflicts: # app/lab/explore-sections.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The treatment tables gain the portal's Intersection, ⓘ and Data download (STS-OT-6).
getPatientTreatmentDownloadData/getSampleTreatmentDownloadData: "Treatment · #" and "Treatment · Pre/Post · #", tab-separated, in the rows' order shown.treatmentClause(level, keys, op),treatmentTableTsvandTREATMENT_TABLE_DESCRIPTIONSinlib/treatment-tables.ts;TreatmentTable;ValueListnow takes the Union / Intersection choice beside its Apply button.Spec IDs
enable_treatment_groupsand AgentClass / AgentTarget data.Verification
Against cbioportal.org: coadread, Fluorouracil and Leucovorin, Intersection: 135 patients. That is the portal's
/filtered-samplescount forpatientTreatmentFilters {filters: [{filters: [Fluorouracil]}, {filters: [Leucovorin]}]}(135 samples, 135 patients).Browser, dev server, coadread:
Treatment_per_Patient.txt, "Treatment\t# / Fluorouracil\t156 / Leucovorin\t137 / …".Unit tests:
test/treatment-tables.test.ts:npm test7,133 pass, 0 fail;tsc --noEmitand eslint clean.Coverage: passes.
Planted bugs: 2 more in
scripts/mutants/study-view/treatment-tables.ts(guardunit).Tracker
Under "Study View → summary charts", this line (docs/PORTAL-PARITY.md:415):
becomes:
Scorecard
30-study-summary.md, row STS-OT-6 (was| STS-OT-6 | 🟡 | B | Treatment per Patient and per Sample (pre/post), equal to the portal's counts (coadread, msk_chord_2024, luad, and others; first-start Pre/Post rule); Union filter (treatmentclause); no Intersection, Compare, ⓘ, download, Groups / Target tiers |):| STS-OT-6 | 🟡 | B | Treatment per Patient and per Sample (pre/post), equal to the portal's counts (coadread, msk_chord_2024, luad, and others; first-start Pre/Post rule); Union or Intersection (
treatmentclauses; coadread Fluorouracil ∩ Leucovorin 135 = the portal's); ⓘ and Download ▸ Data as the portal's; no Compare, Groups / Target tiers |Preview
/lab?tab=explore&study=coadread_tcga_pan_can_atlas_2018: Treatment per Patient, check Fluorouracil and Leucovorin, choose Intersection.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3ezTaCo6wHFVsML6Qd4ht
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.