Skip to content

Support DOM attributes including namespaces - #66

Merged
cowboyd merged 1 commit into
mainfrom
wpt-attributes
Nov 12, 2026
Merged

cowboyd merged 1 commit into
mainfrom
wpt-attributes

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Add the attribute factories and Element attribute operations needed as we work toward Preact integration. Element delegates attribute storage and operations to a separate NamedNodeMap supplied with its dependencies through the constructor. The collection preserves attribute identity, insertion order, namespace matching, and ownership across updates and removals.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@66

commit: c9b664e

@cowboyd
cowboyd added this pull request to stack #63 November 12, 2026 15:59
@cowboyd cowboyd changed the title Support DOM attributes and expand WPT coverage Support DOM attributes including namespaces Nov 12, 2026
@cowboyd
cowboyd force-pushed the wpt-attributes branch 2 times, most recently from 96c89af to bc3ae98 Compare November 12, 2026 16:50
@cowboyd
cowboyd marked this pull request as ready for review November 12, 2026 17:14
@cowboyd
cowboyd requested a review from natemoo-re November 12, 2026 17:31
@cowboyd cowboyd mentioned this pull request Nov 12, 2026
6 of 12 tasks
@cowboyd
cowboyd force-pushed the wpt-attributes branch 2 times, most recently from 46eb93f to d8ded2b Compare November 12, 2026 21:17
Base automatically changed from wpt-create-element-ns to main November 12, 2026 21:53
@cowboyd
cowboyd merged commit fc09ae7 into main Nov 12, 2026
8 of 10 checks passed
@cowboyd
cowboyd deleted the wpt-attributes branch November 12, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant