Skip to content

fix(schema): update ministry names from gov.bc.ca - #710

Merged
DerekRoberts merged 6 commits into
mainfrom
chore/ministry-names-44842089062-1
Nov 21, 2026
Merged

DerekRoberts merged 6 commits into
mainfrom
chore/ministry-names-44842089062-1

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The ministry names in the schema no longer match the official ministries listed at https://www2.gov.bc.ca/gov/content/governments/organizational-structure/ministries-organizations/ministries.

What changes: The schema ministry enum is regenerated to the 18 official ministry names (cabinet sworn in 2026-11-20). Typographic apostrophes are stored as ASCII, and the leftover Tourism, Arts, Culture and Sport entry from the ministries page is omitted. The Cypress new-form test now selects Agriculture. The edit-form test loads bcgov/nr-fom (ministry: Forests) because the previous bcgov/public-code fixture still lists Water, Land and Resource Stewardship. The scraper that produced this list is in #712.

What could go wrong: After this merges, the public form will only accept the new enum. Existing YAML files and stored pubcode records that still use previous ministry names are not migrated in this pull request.

How it was verified: The fixed scraper was run locally in a node:26 container against live gov.bc.ca pages; the ministries-page list and the cabinet ministers list agreed on these 18 names. Cypress updates follow that list.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Replace the unvalidated #body list with the 18 official ministry names, use a straight apostrophe in Citizens' Services and Technology, drop the leftover Tourism, Arts, Culture and Sport entry, and point the Cypress form test at Agriculture.
…stry

The previous fixture (bcgov/public-code) still lists Water, Land and Resource Stewardship, which is no longer in the schema, so the edit form could not produce a valid file.
wps still fails schema validation for reasons unrelated to ministry (duplicate Postgis, spatial values not in the enum). nr-fom lists Forests and otherwise matches the schema, like the original public-code fixture did before the ministry rename.
@github-project-automation github-project-automation Bot moved this from Active to Waiting in DevOps (NR) Nov 21, 2026
@DerekRoberts
DerekRoberts merged commit f1a778b into main Nov 21, 2026
21 checks passed
@DerekRoberts
DerekRoberts deleted the chore/ministry-names-44842089062-1 branch November 21, 2026 20:35
@github-project-automation github-project-automation Bot moved this from Waiting to Done in DevOps (NR) Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore activities

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant