Skip to content

do not let an insecure origin set or overwrite secure cookies - #953

Open
Hsnmohd wants to merge 1 commit into
apache:masterfrom
Hsnmohd:insecure-origin-secure-cookies
Open

Hsnmohd wants to merge 1 commit into
apache:masterfrom
Hsnmohd:insecure-origin-secure-cookies

Conversation

@Hsnmohd

@Hsnmohd Hsnmohd commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

an http:// response can plant or replace secure cookies: BasicSecureHandler enforces Secure only in match, never in validate, and ResponseProcessCookies adds the cookie even when it overwrites a Secure one with the same name, domain and path. a network attacker answering one cleartext request to a host the client also uses over https gets session fixation on the secure origin; reproduced with HttpClients against a local http server, after https://localhost set SESSION=victim; Secure, one http response with Set-Cookie: SESSION=attacker made the next https request send Cookie: SESSION=attacker. reject Secure cookies from an insecure origin in BasicSecureHandler.validate and drop an insecure cookie that would overlay a secure one in ResponseProcessCookies, per RFC 6265bis 5.7 (the "leave secure cookies alone" rule browsers enforce). regression tests in TestBasicCookieAttribHandlers and TestResponseProcessCookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant