Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an http:// response can plant or replace secure cookies: BasicSecureHandler enforces Secure only in match, never in validate, and ResponseProcessCookies adds the cookie even when it overwrites a Secure one with the same name, domain and path. a network attacker answering one cleartext request to a host the client also uses over https gets session fixation on the secure origin; reproduced with HttpClients against a local http server, after https://localhost set SESSION=victim; Secure, one http response with Set-Cookie: SESSION=attacker made the next https request send Cookie: SESSION=attacker. reject Secure cookies from an insecure origin in BasicSecureHandler.validate and drop an insecure cookie that would overlay a secure one in ResponseProcessCookies, per RFC 6265bis 5.7 (the "leave secure cookies alone" rule browsers enforce). regression tests in TestBasicCookieAttribHandlers and TestResponseProcessCookies.