Repository navigation
fix(ci): rename the reserved query variable in issue-status searches - #994
Merged
Merged
Conversation
@octokit/graphql reserves "query" for the document itself and throws when a GraphQL variable has that name, so updateReleaseDescription crashed before writing anything and release PRs never got their "Closes" list. Both search calls now pass the search string as $searchQuery.
Coverage Report for CI Build 43506270690Warning No base build found for commit Coverage: 90.34%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
bencap
marked this pull request as ready for review
November 13, 2026 22:38
bencap
deleted the
bugfix/bencap/issue-status-reserved-query-variable
branch
November 13, 2026 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On release PRs, the issue-status
updatejob crashes with"query" cannot be used as variable name:@octokit/graphqlreservesqueryfor the document itself, and both search calls inupdateReleaseDescriptionused it as a variable. As a result, release PRs never get their "Issues closed by this release" list. This renames the variable to$searchQuery.This targets
maindirectly because the workflow runs onpull_request_target, which usesmain's copy of the script. A fix on a release branch wouldn't reach the open release PRs before they merge. The release branches will need rebasing ontomainafterwards.Tests
Ran the script read-only against the open release PRs (#993, VariantEffect/mavedb-ui#775, VariantEffect/dcd_mapping2#129) using
@octokit/graphql7.1, with writes stubbed. The old copy reproduces the crash; the fixed one builds each Closes list.bin/checkpasses.Checklist
release-<year>.<n>.0branch otherwise; never
main(targetsmainon purpose; see above)mavedb-uiPR regeneratessrc/schema/openapi.d.ts(no schema change)