Skip to content

fix(ci): rename the reserved query variable in issue-status searches - #994

Merged
bencap merged 1 commit into
mainfrom
bugfix/bencap/issue-status-reserved-query-variable
Nov 13, 2026
Merged

bencap merged 1 commit into
mainfrom
bugfix/bencap/issue-status-reserved-query-variable

Conversation

@bencap

@bencap bencap commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

On release PRs, the issue-status update job crashes with "query" cannot be used as variable name: @octokit/graphql reserves query for the document itself, and both search calls in updateReleaseDescription used it as a variable. As a result, release PRs never get their "Issues closed by this release" list. This renames the variable to $searchQuery.

This targets main directly because the workflow runs on pull_request_target, which uses main's copy of the script. A fix on a release branch wouldn't reach the open release PRs before they merge. The release branches will need rebasing onto main afterwards.

Tests

Ran the script read-only against the open release PRs (#993, VariantEffect/mavedb-ui#775, VariantEffect/dcd_mapping2#129) using @octokit/graphql 7.1, with writes stubbed. The old copy reproduces the crash; the fixed one builds each Closes list. bin/check passes.

Checklist

  • Targets the open patch branch if this is a small, non-breaking change, or the cycle's release-<year>.<n>.0
    branch otherwise; never main (targets main on purpose; see above)
  • API schema change? A matching mavedb-ui PR regenerates src/schema/openapi.d.ts (no schema change)
  • Docs and instruction files touched by this change are updated

@octokit/graphql reserves "query" for the document itself and throws
when a GraphQL variable has that name, so updateReleaseDescription
crashed before writing anything and release PRs never got their
"Closes" list. Both search calls now pass the search string as
$searchQuery.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 43506270690

Warning

No base build found for commit 7c482dd on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 90.34%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 19183
Covered Lines: 17330
Line Coverage: 90.34%
Coverage Strength: 0.9 hits per line

💛 - Coveralls

@bencap
bencap marked this pull request as ready for review November 13, 2026 22:38
@bencap
bencap merged commit 9e11f4e into main Nov 13, 2026
7 checks passed
@bencap
bencap deleted the bugfix/bencap/issue-status-reserved-query-variable branch November 13, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants