Skip to content

fix(ci): rename the reserved query variable in issue-status searches - #130

Merged
bencap merged 6 commits into
mavedb-mainfrom
bugfix/bencap/issue-status-reserved-query-variable
Nov 13, 2026
Merged

bencap merged 6 commits into
mavedb-mainfrom
bugfix/bencap/issue-status-reserved-query-variable

Conversation

@bencap

@bencap bencap commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

On release PRs, the issue-status update job crashes with "query" cannot be used as variable name: @octokit/graphql reserves query for the document itself, and both search calls in updateReleaseDescription used it as a variable. As a result, release PRs never get their "Issues closed by this release" list. This renames the variable to $searchQuery, matching VariantEffect/mavedb-api and VariantEffect/mavedb-ui.

Tests

Ran the script read-only against the open release PRs (VariantEffect/mavedb-api#993, VariantEffect/mavedb-ui#775, #129) using @octokit/graphql 7.1, with writes stubbed. The old copy reproduces the crash; the fixed one builds each Closes list. bin/check passes.

Checklist

  • Targets mavedb-dev, not mavedb-main
  • Docs and instruction files touched by this change are updated

bencap and others added 6 commits November 12, 2026 12:28
bin/check-todos fails when a line added since the merge base has a
TODO, FIXME, XXX or HACK that doesn't cite an issue as TODO(#123) or
TODO(owner/repo#123). It checks only added lines, so the TODOs already
in the tree pass until someone edits them. bin/check runs it, and the
CI check job fetches full history so it can find the PR's merge base.

The same script lives in the other MaveDB repos and the workspace.

Expect: agents write new TODOs as TODO(#N) and file or find an issue
first, instead of leaving bare TODOs.
Cites dcd_mapping2#125 and #126 for the mixed-target and accession-prefix
TODOs, and removes TODOs that were already done or described work
nobody needs: the Dockerfile's pg-dependency note (pyproject.toml
declares gene_normalizer[etl,pg]), a docstring bullet for a field that
no longer exists, and the non-coding-target TODO, since regulatory
elements have no HGNC symbol to select. TODOs with no clear issue are
left for later.
cdot 0.2.37 gave cdot.hgvs.dataproviders an explicit __all__, which
dropped the biocommons hgvs SeqFetcher that earlier versions re-exported
by accident through a star import. The mapper failed to import on a
fresh install, so CI's lint and test jobs both failed.
…sue-refs

ci: require an issue reference on new TODOs
@octokit/graphql reserves "query" for the document itself and throws
when a GraphQL variable has that name, so updateReleaseDescription
crashed before writing anything and release PRs never got their
"Closes" list. Both search calls now pass the search string as
$searchQuery.
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 0.0%. remained the same — bugfix/bencap/issue-status-reserved-query-variable into mavedb-dev

@bencap
bencap marked this pull request as ready for review November 13, 2026 22:38
@bencap
bencap changed the base branch from mavedb-dev to mavedb-main November 13, 2026 23:01
@bencap
bencap merged commit 8f768f6 into mavedb-main Nov 13, 2026
5 checks passed
@bencap
bencap deleted the bugfix/bencap/issue-status-reserved-query-variable branch November 13, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants