Skip to content

Power sort comparable - #15752

Closed
NEHoward wants to merge 2 commits into
TheAlgorithms:masterfrom
NEHoward:power-sort-comparable
Closed

Power sort comparable#15752
NEHoward wants to merge 2 commits into
TheAlgorithms:masterfrom
NEHoward:power-sort-comparable

Conversation

@NEHoward

@NEHoward NEHoward commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

NEHoward and others added 2 commits November 12, 2026 22:48
@NEHoward
lab6
4a5d32b
@NEHoward @claude
sorts: bind power_sort to Comparable protocol
9ebd340 
Replace Any in power_sort.py with a Comparable Protocol and a bound
TypeVar, matching the pattern used by the other converted sorts.

- Comparable declares __lt__ and __le__, because the merge step uses
  <= and run detection uses >=
- key is typed Callable[[T], Comparable] | None
- runtime behaviour and doctests are unchanged

Part of TheAlgorithms#15234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Vz9kdTTotzsNfBpvemeuk
@NEHoward
NEHoward requested a review from cclauss as a code owner November 13, 2026 05:54
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Nov 13, 2026
@algorithms-keeper

algorithms-keeper Bot commented Nov 13, 2026

Copy link
Copy Markdown

Closing this pull request as invalid

@NEHoward, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper
algorithms-keeper Bot removed the request for review from cclauss November 13, 2026 05:54
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NEHoward