Skip to content

chore(ty): rename stale rule names and un-ignore not-callable - #15749

Open
GeorgeLey wants to merge 1 commit into
TheAlgorithms:masterfrom
GeorgeLey:ty/unignore-zero-count-rules
Open

chore(ty): rename stale rule names and un-ignore not-callable#15749
GeorgeLey wants to merge 1 commit into
TheAlgorithms:masterfrom
GeorgeLey:ty/unignore-zero-count-rules

Conversation

@GeorgeLey

@GeorgeLey GeorgeLey commented Nov 13, 2026

Copy link
Copy Markdown

Describe your change

Part of #15187 (gradual ty baseline).

ty 0.0.102 renamed four of the rules in the [tool.ty] ignore list, so every run
emitted a renamed-rule warning for them. This PR:

  • Renames the ignore keys to their current names:
    invalid-return-type → invalid-explicit-return,
    unresolved-attribute → missing-attribute,
    unresolved-import → import-not-found.
  • Un-ignores not-callable (formerly call-non-callable) after fixing its only
    diagnostic: DenseLayer.activation could be None when called in
    forward_propagation. The sigmoid default now happens in __init__ (it used
    to happen in initializer()), and the parameters are type-hinted. Behavior is
    unchanged.

ty check --exclude-scripts goes from 51 to 47 diagnostics, with no not-callable
or renamed-rule diagnostics left.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

The type-hint and doctest boxes are unchecked because the rest of this file predates
them; this PR keeps to the ty fix (the template asks not to mix code and test
changes). No "Fixes" keyword because #15187 is a tracking issue that should stay open.

🤖 Generated with Claude Code

@GeorgeLey @claude
chore(ty): rename stale rule names and un-ignore not-callable
85aa783 
ty 0.0.102 renamed four rules in the [tool.ty] ignore list, so every run
emitted renamed-rule warnings. Use the current names
(invalid-explicit-return, missing-attribute, import-not-found) and drop
not-callable (formerly call-non-callable) from the list after fixing its
only diagnostic: DenseLayer.activation could be None when called, so the
sigmoid default now happens in __init__ and the parameters are typed.

Part of TheAlgorithms#15187

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GeorgeLey