Repository navigation
Add per-parse runtime hooks for Unicode names and literal diagnostics - #9
Merged
youknowone merged 1 commit intoNov 15, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
youknowdot
force-pushed
the
unicode-name-provider
branch
from
November 14, 2026 05:02
3abeb93 to
71f341c
Compare
youknowone
force-pushed
the
pr-7-runtime-base
branch
from
November 14, 2026 10:10
19a5e16 to
cd0390f
Compare
youknowdot
force-pushed
the
unicode-name-provider
branch
3 times, most recently
from
November 14, 2026 16:43
7a06ac3 to
38f9ce8
Compare
Keep decoder failures across diagnostic backtracking and dispatch literal warnings in grammar action order. Preserve format-spec exception provenance and retain standalone parser behavior. Assisted-by: Codex:gpt-6.1-sol
youknowdot
force-pushed
the
unicode-name-provider
branch
from
November 14, 2026 17:00
38f9ce8 to
4f370b7
Compare
youknowone
marked this pull request as ready for review
November 15, 2026 01:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add interpreter runtime hooks at Python literal decoding boundaries on
rustpython-0.17.5.UnicodeNameProviderandParseRuntimeinterfaces andparse_unchecked_with_runtime.The target branch already contains #7. This PR adds only the runtime-hook implementation and its focused tests; it does not duplicate #7 or add PEP 798 grammar support.
Validation
The complete parser test suite passes, including existing fixtures and snapshots, three diagnostic tests, twenty runtime-hook tests, and doctests. Parser all-target Clippy and changed-file checks pass with the pinned Rust 1.99.0 toolchain. Existing fixture snapshots are unchanged.