Repository navigation
Mac: Fix drag mouse coords - #371
Open
AlexCharlton wants to merge 1 commit into
Open
AlexCharlton wants to merge 1 commit into
AlexCharlton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on Mac, the y-coordinates of drag events are in a different coordinate space from
MouseEvent::CursorMoved: The origin is bottom-left of the window rather than top-left. There's nothing documented that indicates that this would be the case, and this is contrary to the behaviour on other platforms.This PR aligns the drag event coords with
CursorMoved, performing the same conversion asmouse_moved.