Repository navigation
Drop allow flags from model annotations - #428
Merged
Merged
Conversation
--warnNonStandardModelica reports non-standard Modelica unless --allowNonStandardModelica allows it. Some models set that flag in their __OpenModelica_commandLineOptions annotation (IDEAS LIDEAS.Validation), and omc applies the annotation during the translation. Thus these models give no warning and are not marked invalid. If --warnNonStandardModelica is in the commands, testmodel.py now sets --ignoreCommandLineOptionsAnnotation and applies the other flags of the annotation itself. The .err file tells which flags it used. See #426. Assisted-by: Claude Opus 5.5
sjoelund
enabled auto-merge (squash)
November 17, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--warnNonStandardModelica reports non-standard Modelica unless --allowNonStandardModelica allows it. Some models set that flag in their __OpenModelica_commandLineOptions annotation (IDEAS LIDEAS.Validation), and omc applies the annotation during the translation. Thus these models give no warning and are not marked invalid.
If --warnNonStandardModelica is in the commands, testmodel.py now sets --ignoreCommandLineOptionsAnnotation and applies the other flags of the annotation itself. The .err file tells which flags it used.
See #426.
Assisted-by: Claude Opus 5.5