Repository navigation
Test the data reconciliation libraries with the new backend - #425
Merged
Merged
Conversation
The new backend can reconcile since OpenModelica #17546 (OpenModelica #16873). Test the data reconciliation libraries of OpenModelica #14817 with it too, and compare the two backends in one overview. - configs/dataReconciliation-newBackend.json: the configuration of configs/dataReconciliation.json with --newBackend. - .CI/Jenkinsfile: parameter dataReconciliation_newBackend and stage dataReconciliation-newBackend, filling the branch of that name. The branch gets report emails and plots, and overview-dataReconciliation.html is built from both branches. - README.md: mention the new configuration. Tested locally with test.py and report.py, omc v1.28.0-dev.1860: 49 of 66 models reconcile with the old backend and 44 with the new one. The Jenkinsfile was not run. Assisted-by: Claude Fable 5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new backend can reconcile since OpenModelica #17546 (OpenModelica/OpenModelica#16873). This tests the data reconciliation libraries of OpenModelica/OpenModelica#14817 with it too, next to the old backend run, and puts both in one overview.
--newBackendadded to the custom command.dataReconciliation_newBackendand stagedataReconciliation-newBackend(ryzen-5950x-1), which fill the branchdataReconciliation-newBackend. The branch is added to the report emails and plots, andoverview-dataReconciliation.htmlis built fromdataReconciliationanddataReconciliation-newBackend, so every library has a row per backend and the cells list the models that differ.The existing
dataReconciliationjob is unchanged. To get both rows, the launcher job has to setdataReconciliation_newBackendas well.Tested locally with omc v1.28.0-dev.1860+ge89ef0a through test.py for both configurations and report.py for the two branches; the Jenkinsfile was not run.
ModelicaDataReconciliationSimpleTests gives 27 of 29 with both backends. In TSP_DataReconciliationSimpleTests the old backend gives 22 of 37 and the new one 17; TSP_FourFlows8 reconciles only with the new backend, and TSP_FourFlows3, 4, 7, 10, TSP_Splitter5 and SG_DR_WithHARE only with the old one. The new backend run writes the report pages the
(dr)links point to (56 models, 61 with the old backend).Assisted-by: Claude Fable 5.2