Repository navigation
Export the FMUs with --fmiFilter=internal - #424
Merged
Merged
Conversation
An FMU run writes only the variables of the modelDescription.xml to the result file. The default --fmiFilter=protected removes all protected variables from it, so -emit_protected cannot add them. simulate() writes them, and the references contain them, for example the protected controlBus of Modelica.Blocks.Examples.BusUsage. Since OpenModelica #17888, diffSimulationResults fails when a variable of the reference is not in the result. Before, it ignored the variable. The wasm-jit-cs run of 2026-11-16 had 1269 such Verify -> Simulate rows that master and wasm-jit verify. - testmodel.py: when the model has a reference, export the FMU with --fmiFilter=internal. This applies to the wasm FMU runners and to the FMI lanes. Tested with a two-model library through test.py --wasmfmu=me,cs: a model that extends BusUsage went from Verify -> Simulate (3 bus signals missing) to verified in both lanes. In a sample of 28 failing rows from 7 libraries, 24 had all missing variables in the modelDescription.xml after the change. The other 4 lacked only names that simulate() also does not write (CPUtime, NonlinearSystems.*, constants), which the verification already skips. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An FMU run writes only the variables of the modelDescription.xml to the result file. The default --fmiFilter=protected removes all protected variables from it, so -emit_protected cannot add them. simulate() writes them, and the references contain them, for example the protected controlBus of Modelica.Blocks.Examples.BusUsage.
Since OpenModelica #17888, diffSimulationResults fails when a variable of the reference is not in the result. Before, it ignored the variable. The wasm-jit-cs run of 2026-11-16 had 1269 such Verify -> Simulate rows that master and wasm-jit verify.
Tested with a two-model library through test.py --wasmfmu=me,cs: a model that extends BusUsage went from Verify -> Simulate (3 bus signals missing) to verified in both lanes. In a sample of 28 failing rows from 7 libraries, 24 had all missing variables in the modelDescription.xml after the change. The other 4 lacked only names that simulate() also does not write (CPUtime, NonlinearSystems.*, constants), which the verification already skips.
Assisted-by: Claude Opus 5.5