Repository navigation
Use the csv-compare tolerance for the csv-compare tubes - #423
Merged
Merged
Conversation
The rectangle and ellipse tubes of diffSimulationResults use rangeDelta as the csv-compare tolerance. It sets the tube width in x and, through the ratio of the two axes, also the tube height. testmodel.py passed reference_rangeDelta (1e-3) to every tube: for rectangle that is a tube height of 0.1% of the range of the reference, half of what csv-compare uses by default (0.002). The default of rangeDelta in diffSimulationResults is that same 0.002. Of the 216 sampled models that fail with rectangle in OpenModelica #18121, 172 fail at 1e-3 and 93 at 0.002, both with the start and stop time fix for these tubes in OpenModelica. - testmodel.py: for reference_tube rectangle or ellipse, do not pass rangeDelta, so that diffSimulationResults uses its default, unless the configuration has a reference_tolerance. ellipse2014 keeps reference_rangeDelta. - test.py: --reference_tolerance sets reference_tolerance for every library, and the report names it. - README.md: document reference_tolerance. Runs without a reference_tube do not change, and neither does their confighash. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rectangle and ellipse tubes of diffSimulationResults use rangeDelta as the csv-compare tolerance. It sets the tube width in x and, through the ratio of the two axes, also the tube height. testmodel.py passed reference_rangeDelta (1e-3) to every tube: for rectangle that is a tube height of 0.1% of the range of the reference, half of what csv-compare uses by default (0.002). The default of rangeDelta in diffSimulationResults is that same 0.002. Of the 216 sampled models that fail with rectangle in OpenModelica #18121, 172 fail at 1e-3 and 93 at 0.002, both with the start and stop time fix for these tubes in OpenModelica.
Runs without a reference_tube do not change, and neither does their confighash.
Assisted-by: Claude Opus 5.5