Repository navigation
Put LEPSE back as OMLET - #421
Merged
Merged
Conversation
LEPSE was removed from configs/conf.json in OpenModelica#414 because it did not parse. The problems are fixed and the library is now called OMLET (AndrejFlorinskii/OMLET#5, OpenModelica/OMPackageManager#103). - .CI/installLibraries.mos: install OMLET main instead of LEPSE main, which leaves the package index with OMPackageManager#103. - configs/conf.json: test OMLET main. The reference files of LEPSE-ref are named LEPSE.Examples.* and are for models that no longer exist, so no reference files are configured. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEPSE was removed from
configs/conf.jsonin #414 because it did not parse. The author fixed the problems and renamed the library to OMLET (AndrejFlorinskii/OMLET#5). OpenModelica/OMPackageManager#103 replaces LEPSE by OMLET in the package index.OpenModelica/OMPackageManager#103 is merged and the package index has
OMLET1.2.7 andmain;LEPSEis no longer there, so master'sinstallLibraries.mosfails until this is merged.Changes
.CI/installLibraries.mos:{"OMLET", "main"}instead of{"LEPSE", "main"}.configs/conf.json: anOMLETentry formain. The old entry used the reference files ofAndrejFlorinskii/LEPSE-ref. They are namedLEPSE.Examples.*and are for models that are no longer in the library (KKT_1,Simple_model,three_maschine_scheme), so the new entry has no reference files.Tests
With omc v1.28.0-dev.1860 and OMLET
main(a301823):loadFile("OMLET/package.mo")givestruewith no errors.Of the 5 models in
OMLET.Examples,Simple_model_with_IB_simpleandSimple_model_with_IB_and_ATsimulate.KKT_base,KKT_diplomaand_3_maschine_scheme_IB_newfail in the frontend with errors in the models (e.g.Variable G54.dUtr_pin not found in scope Submodel3).CI: the "Check if .CI/installLibraries.mos works" step passes on Ubuntu and Windows now that OMLET is in the index.
Not run:
test.pywith the new entry.🤖 Generated with Claude Code