Repository navigation
[CSTACKEX-282] QoS Automation - #140
Open
suryag1201 wants to merge 2 commits into
Open
suryag1201 wants to merge 2 commits into
suryag1201 wants to merge 2 commits into
Conversation
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.83% |
| Branch coverage | 20.11% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QoS Automation
The same 28 cases run for both iSCSI and NFS3.
•
test_01_fixed_disk_without_iops: A fixed disk with no IOPS creates the volume and no ONTAP policy.
•
test_02_fixed_disk_max_iops_only: A fixed disk with only a maximum maps to cs_0_to_{max}.
•
test_03_fixed_disk_min_and_max_iops: Minimum and maximum IOPS are applied on AFF and rejected on FAS.
•
test_04_fixed_disk_min_iops_only: A minimum with no maximum is applied on AFF and rejected on FAS.
•
test_05_custom_size_disk_with_fixed_iops: A custom-size disk keeps the IOPS written on the offering.
•
test_06_custom_iops_disk_max_only: Custom IOPS with a zero minimum stores only the maximum.
•
test_07_custom_iops_disk_min_and_max: Custom minimum and maximum IOPS are applied on AFF and rejected on FAS.
•
test_08_custom_size_and_custom_iops: Size and IOPS can both be chosen when the volume is created.
•
test_09_provisioning_types_keep_iops: Thin, sparse, and fat disks still receive a max-only QoS policy.
•
test_10_shared_policy_survives_until_last_volume: Two volumes with the same IOPS share a policy until both are gone.
•
test_11_resize_replaces_qos_policy: Resizing onto another disk offering replaces the QoS policy.
•
test_12_resize_clears_qos_policy: Resizing onto a disk offering without IOPS removes the policy.
•
test_13_reject_disk_offering_min_above_max: A disk offering whose minimum exceeds its maximum is rejected.
•
test_14_reject_disk_offering_min_iops_zero: The disk-offering API rejects a minimum of zero when a maximum is set.
•
test_15_reject_custom_iops_min_above_max: Custom IOPS on the volume are rejected when the minimum is above the maximum.
•
test_16_reject_pool_iops_capacity: A minimum above the pool IOPS capacity is rejected on AFF.
•
test_17_fixed_compute_override_qos_disk: A fixed compute offering plus an override disk applies that disk's QoS.
•
test_18_compute_offering_with_its_own_iops: IOPS set on the compute offering are applied to its implicit root disk.
•
test_19_compute_bound_to_qos_disk: A compute offering bound to a disk offering uses that disk's QoS.
•
test_20_strict_compute_rejects_disk_override: A strict compute offering rejects a different disk at deploy.
•
test_21_custom_compute_with_qos_disk: A custom compute offering deploys with the QoS of its bound disk.
•
test_22_custom_compute_custom_root_disk: Custom CPU and a custom root disk apply the IOPS given at deploy.
•
test_23_custom_iops_on_compute_offering: A compute offering with custom IOPS takes minimum and maximum from deploy details.
•
test_24_root_without_iops_and_qos_data_disk: A plain root disk stays unlimited while the attached data disk has a policy.
•
test_25_root_and_data_use_different_policies: Root and data disks keep the different policies from their offerings.
•
test_26_hypervisor_rate_limits_do_not_create_ontap_policy: Hypervisor byte and IOPS rates are not an ONTAP QoS policy.
•
test_27_constrained_compute_fixed_iops: Constrained CPU and memory deploy with the bound disk's fixed IOPS.
•
test_28_constrained_compute_custom_iops: Constrained CPU and memory deploy with IOPS chosen at deploy.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Test
Description
iSCSI
NFS3
test_01_fixed_disk_without_iops
A fixed disk with no IOPS creates the volume and no ONTAP policy.
Pass
Pass
test_02_fixed_disk_max_iops_only
A fixed disk with only a maximum maps to cs_0_to_{max}.
Pass
Pass
test_03_fixed_disk_min_and_max_iops
Minimum and maximum IOPS are applied on AFF and rejected on FAS.
Pass
Pass
test_04_fixed_disk_min_iops_only
A minimum with no maximum is applied on AFF and rejected on FAS.
Pass
Pass
test_05_custom_size_disk_with_fixed_iops
A custom-size disk keeps the IOPS written on the offering.
Pass
Pass
test_06_custom_iops_disk_max_only
Custom IOPS with a zero minimum stores only the maximum.
Pass
Pass
test_07_custom_iops_disk_min_and_max
Custom minimum and maximum IOPS are applied on AFF and rejected on FAS.
Pass
Pass
test_08_custom_size_and_custom_iops
Size and IOPS can both be chosen when the volume is created.
Pass
Pass
test_09_provisioning_types_keep_iops
Thin, sparse, and fat disks still receive a max-only QoS policy.
Pass
Pass
test_10_shared_policy_survives_until_last_volume
Two volumes with the same IOPS share a policy until both are gone.
Pass
Pass
test_11_resize_replaces_qos_policy
Resizing onto another disk offering replaces the QoS policy.
Pass
Pass
test_12_resize_clears_qos_policy
Resizing onto a disk offering without IOPS removes the policy.
Pass
Pass
test_13_reject_disk_offering_min_above_max
A disk offering whose minimum exceeds its maximum is rejected.
Pass
Pass
test_14_reject_disk_offering_min_iops_zero
The disk-offering API rejects a minimum of zero when a maximum is set.
Pass
Pass
test_15_reject_custom_iops_min_above_max
Custom IOPS on the volume are rejected when the minimum is above the maximum.
Pass
Pass
test_16_reject_pool_iops_capacity
A minimum above the pool IOPS capacity is rejected on AFF.
Skip
Skip
test_17_fixed_compute_override_qos_disk
A fixed compute offering plus an override disk applies that disk's QoS.
Pass
Pass
test_18_compute_offering_with_its_own_iops
IOPS set on the compute offering are applied to its implicit root disk.
Pass
Pass
test_19_compute_bound_to_qos_disk
A compute offering bound to a disk offering uses that disk's QoS.
Pass
Pass
test_20_strict_compute_rejects_disk_override
A strict compute offering rejects a different disk at deploy.
Pass
Pass
test_21_custom_compute_with_qos_disk
A custom compute offering deploys with the QoS of its bound disk.
Pass
Pass
test_22_custom_compute_custom_root_disk
Custom CPU and a custom root disk apply the IOPS given at deploy.
Pass
Pass
test_23_custom_iops_on_compute_offering
A compute offering with custom IOPS takes minimum and maximum from deploy details.
Pass
Pass
test_24_root_without_iops_and_qos_data_disk
A plain root disk stays unlimited while the attached data disk has a policy.
Pass
Pass
test_25_root_and_data_use_different_policies
Root and data disks keep the different policies from their offerings.
Pass
Pass
test_26_hypervisor_rate_limits_do_not_create_ontap_policy
Hypervisor byte and IOPS rates are not an ONTAP QoS policy.
Pass
Pass
test_27_constrained_compute_fixed_iops
Constrained CPU and memory deploy with the bound disk's fixed IOPS.
Pass
Pass
test_28_constrained_compute_custom_iops
Constrained CPU and memory deploy with IOPS chosen at deploy.
Pass
Pass
test_16 was skipped on both protocols because the cluster is FAS. That case checks pool IOPS capacity, which is enforced on minimum IOPS, and FAS rejects a minimum above 0 before that check.
How did you try to break this feature and the system with this change?