Repository navigation
Document that a real SF Symbol name draws as itself on iOS - #614
Open
wojt-janowski wants to merge 2 commits into
Open
wojt-janowski wants to merge 2 commits into
wojt-janowski wants to merge 2 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1df8b-2dad-7068-b8b2-8cffd4f33e8b Co-authored-by: Wojt Janowski <wojt@clinically.com.au>
4 of 5 tasks
Amp-Thread-ID: https://ampcode.com/threads/T-01a1df8b-2dad-7068-b8b2-8cffd4f33e8b Co-authored-by: Wojt Janowski <wojt@clinically.com.au>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents NativePHP/mobile-air#695, which fixes NativePHP/mobile-air#650: on iOS, an icon name that is already an SF Symbol (
heart,phone,star, …) now draws that symbol as written instead of going through the alias table. Merge it with or after #695.heartandstarnow draw the outline symbol. To get the filled one, ask forheart.fill/Ios::HeartFillor use an alias such asfavorite. Android draws the filled Material icon for the same shared name, so there's an example that gives each platform its own name.forward,info,mail,smartphone,speaker,location) and the alias to use for matching icons.The three changed spots carry a
changed="4.9"badge, for the release #695 is expected to land in.Testing
php artisan test --filter=Documentation: 8 passed.