Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary
Change: Feature Merge Risk:
|
2f0e7cf to
538bef3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

Major · important: Scope the nSpect fallback to this repository. · security-suite.yml:56
.github/workflows/security-suite.yml:56
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winimportant: Scope the nSpect fallback to this repository.
Line 56 applies
NSPECT-ZY2K-Y1V8to every caller whenvars.NSPECT_IDis empty. The job condition also permits another repository to opt in throughCI_CUSTOMIZATIONS_SECURITY_SUITE_ENABLED. The reusable workflow definesnspect-idas the calling repository's registration, so another repository can attribute both scan results to cuda-python's registration. Scope the fallback toNVIDIA/cuda-pythonand fail or skip when another repository has noNSPECT_ID. (raw.githubusercontent.com)Source: Path instructions

Review info
-
Run configuration-
- Source mode: Auto
- Repository: NVIDIA/cuda-python
- Branch: main
- File: .coderabbit.yaml
- Commit: 590a8bf
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
6a8de3fc-b2c9-4bc1-bfb8-beb92c5fa8bc
Files selected for processing: 1-
.github/workflows/security-suite.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.
-
|
There was a problem hiding this comment.

Review info
-
Run configuration-
- Source mode: Auto
- Repository: NVIDIA/cuda-python
- Branch: main
- File: .coderabbit.yaml
- Commit: 590a8bf
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
7cafac23-48d5-40ca-95ff-f532ee87b70c
Files selected for processing: 1-
.github/workflows/security-suite.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
-
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aa743d9 to
59e7442
Compare
|
/ok to test 59e7442 |
|
/ok to test bb07086 |
|
/ok to test 5d8f919 |
|
/ok to test 9a2dd68 |
|
/ok to test a3d6ace |
|
/ok to test 6b57543 |
|
/ok to test 0202fd0 |
|
/ok to test a13567c |
…Suite Turns on enable-vuln-scan and enable-malware-scan and moves every security-workflows pin -- the reusable suite and the secret-scan pre-commit hook -- to the v0.5.0 release commit, the first release carrying either workflow. The vulnerability scan starts report-only so a finding baseline can be built before it gates merges; scanner and transport errors still fail the job, and inventory writeback stays off. The malware scan keeps the upstream default of strict, where SUSPICIOUS blocks as well as MALICIOUS. On main the vulnerability scan inspects installed wheels, because Detect cannot resolve cuda_core's CUDA-dependent build or cuda_python's dynamic setup.py from source; two new jobs build and collect them. Wheel mode is refused on pull-request/* mirrors, which instead scan source with those two packages excluded. Both scans report to the same nSpect registration, because an nSpect ID identifies the repository rather than one scan. nspect-id reads the NSPECT_ID Actions variable -- a reusable workflow's inputs cannot read secrets -- and an empty value fails the suite preflight rather than reporting to the wrong program. No permission change: the suite's union is contents/actions read plus id-token and security-events write, all of which this caller already grants. Both scans cross a Charon tunnel that authorizes per repository and per ref; the prerequisites are summarised in ci/README.md.
a13567c to
1bd3b7d
Compare
|
/ok to test 1bd3b7d |
|
/ok to test aff64b7 |
…nboarding # Conflicts: # ci/README.md
| build-wheels: | ||
| name: Build wheels for the vulnerability scan | ||
| needs: wheel-plan | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| secrets: inherit | ||
| uses: ./.github/workflows/build-wheel.yml | ||
| with: | ||
| host-platform: linux-64 | ||
| workplan: ${{ needs.wheel-plan.outputs.workplan }} | ||
| single-cuda-major: true |
There was a problem hiding this comment.
This seems more complex than necessary. What is the reason to build a wheel here, instead of just adding a job in ci.yml that waits for a wheel build to finish and then download it?
There was a problem hiding this comment.
The said job can invoke this workflow, and everything you do below can be used.
There was a problem hiding this comment.
Same suggestion, and I did try it — ci.yml calling this workflow after
build-linux-64, keeping everything below line 88. The wiring is fine; the
wheels aren't.
ci.yml's matrix is sharded, so no single run has a complete set for one
interpreter. A recent main run had bindings for 3.12/cu12.9.1 and for
3.14t + 3.15t/cu13.5.0, and core for 3.15 — so 3.12 has bindings but no core,
3.15 the reverse. cuda-* also matches 38 artifacts there, including win-64
and aarch64, so pip download fails on the first incompatible wheel.
Pulse installs offline and needs one coherent set: one interpreter, one CUDA
major, all runtime deps. Reusing ci.yml's wheels would mean forcing it to
always build a complete 3.12 set — the same work, moved onto everyone's
critical path.
| # Pull-request mirrors scan source, minus the two packages Detect cannot resolve from it. | ||
| vuln-detect-properties: >- | ||
| ${{ github.ref == 'refs/heads/main' && '{}' || | ||
| '{"detect.excluded.directories": "cuda_core,cuda_python"}' }} |
There was a problem hiding this comment.
Q: so we ignore those two directories?
There was a problem hiding this comment.
On pull-request mirrors only. Mirrors have no wheels, and Detect can't resolve
cuda_core's CUDA-dependent build or cuda_python's dynamic setup.py from
source, so it skips them rather than emitting detector errors. On main the
scan uses the built wheels and covers both. Comment updated to say so.
…nboarding # Conflicts: # .github/workflows/security-suite.yml
Turns on
enable-vuln-scanandenable-malware-scan, and moves every NVIDIA/security-workflows pin — the reusable suite and the pre-commit hooks — tod8189f3176942de7ffe2c48bcd7bb5fbdee2dd15, the v0.6.0 release commit.The vulnerability scan starts report-only so a finding baseline can be built before it gates merges; scanner and transport errors still fail the job, and inventory writeback stays off. The malware scan keeps the upstream default of strict, where SUSPICIOUS blocks as well as MALICIOUS.
On
mainthe vulnerability scan inspects installed wheels, because Detect cannot resolvecuda_core's CUDA-dependent build orcuda_python's dynamicsetup.pyfrom source; two new jobs build and collect them. Wheel mode is refused onpull-request/*mirrors, which instead scan source with those two packages excluded.Both scans report to the same nSpect registration, because an nSpect ID identifies the repository rather than one scan.
nspect-idreads theNSPECT_IDActions variable — a reusable workflow's inputs cannot read secrets, so it must be a variable, not a secret — and an empty value fails the suite preflight rather than reporting to the wrong program.Both scans cross a Charon tunnel that authorizes per repository and per ref. charon!242 grants this repository
mainplus thepull-request/*mirrors, so the vulnerability and malware scans are enabled only on those refs; the secret scan and CodeQL still run on every trigger. The prerequisites are summarised inci/README.md.The GuardWords pre-commit hook (
guardwords-scan-code-scanning) is added alongsidesecret-scan-trufflehog. It scans commits for NVIDIA employees who have the internal client installed, and skips with a notice for everyone else, including external contributors and pre-commit.ci, where it is also listed inci.skip.The workflow is renamed to "Security Suite (Secret, Vulnerability, Malware, SAST)" so its name covers every scan it runs.
No permission change: the suite's union is contents/actions read plus id-token and security-events write, all of which this caller already grants.
Status check rename (v0.6.0): the secret-scan check is now
Security Suite / Secret scan (Pulse) / pulse-secretinstead of… / pulse. If branch protection requires the old check name, update the rule when this merges.Description
closes
Checklist