Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1264
Hi! Thanks for maintaining asyncpg.
copy_from_query()/copy_table()can silently lose output when the server sends a NoticeResponse between CopyData messages (for example a function that doesRAISE NOTICE, or PostGIS coercion notices like in the issue).Cause: in
_parse_copy_data_msgs(coreproto.pyx) the consumed CopyData bytes are assigned toself.result. If a non-CopyData message is next in the buffer, the result is intentionally not pushed yet. After the notice is handled, the next CopyData batch overwritesself.result, so the earlier bytes (including the CSV header) are dropped.Fix: append to
self.resultwhen it already holds unpushed data.Test:
test_copy_from_query_with_notices(a plpgsql function raising a notice per row, csv with header). Without the fix only3,4is returned; with it the header and all rows are returned.tests/test_copy.pyandtests/test_listeners.pypass on PostgreSQL 18 (37 passed, 2 skipped).