Repository navigation
Assert frame ownership is correct when popping a frame (debug only) - #2172
Merged
Merged
Conversation
slozier
approved these changes
Nov 18, 2026
slozier
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional/performance changes in release builds (except for a small bugfix in
OnDiskScriptCode.Run; is it even being used?)In debug builds, frame pops from the framestack check if the frame being poped is the frame that was pushed by the same function. Popping a wrong frame can silently (or loudly) corrupt the frame stack. This check for generators was already done in #2146 and for coroutines in #2167. There was no such check for regular functions.
The check has already proven worthwhile: it exposed a bug in the DLR; I'll come with a PR for that.